[igt-dev] [PATCH] tests/kms_concurrent: remove an AMD device check

Mark Yacoub markyacoub at chromium.org
Fri Aug 26 18:16:31 UTC 2022


On Thu, Aug 25, 2022 at 2:21 PM Alex Hung <alex.hung at amd.com> wrote:
>
>
>
> On 2022-08-25 08:37, Mark Yacoub wrote:
> > On Thu, Aug 25, 2022 at 3:54 AM Alex Hung <alex.hung at amd.com> wrote:
> >>
> >> This is to be deprecated by a kernel fix.
> > Can you link the kernel commit for reference
>
> The kernel and IGT patches are inter-dependent. This patch is required
> to avoid regression from kernel testing and that's the reason I
> submitted IGT patch first.
sounds good. Always good removing driver specific checks.
>
> >>
> >> Signed-off-by: Alex Hung <alex.hung at amd.com>
Reviewed-by: Mark Yacoub <markyacoub at chromium.org>
> >> ---
> >>   tests/kms_concurrent.c | 2 --
> >>   1 file changed, 2 deletions(-)
> >>
> >> diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
> >> index 6f8ffd4a..3ad51569 100644
> >> --- a/tests/kms_concurrent.c
> >> +++ b/tests/kms_concurrent.c
> >> @@ -276,8 +276,6 @@ test_resolution_with_output(data_t *data, enum pipe pipe, int max_planes, igt_ou
> >>                  /* switch to lower resolution */
> >>                  igt_output_override_mode(output, mode_lo);
> >>                  free(mode_lo);
> >> -               if (is_amdgpu_device(data->drm_fd))
> >> -                       igt_output_set_pipe(output, PIPE_NONE);
> >>                  igt_display_commit2(&data->display, COMMIT_ATOMIC);
> >>
> >>                  /* switch back to higher resolution */
> >> --
> >> 2.37.2
> >>


More information about the igt-dev mailing list