[igt-dev] [PATCH] tests/kms_plane: check before calling i915 libraries

Andrzej Hajda andrzej.hajda at intel.com
Fri Dec 2 07:53:24 UTC 2022



On 29.11.2022 23:03, Alex Hung wrote:
> for_each_memory_region calls functions in lib/i915/ and let's
> check is_i915_device first.
>
> Fixes: db2bdd3a (tests/kms_plane: skip memory demanding modes in test_plane_panning)
> Signed-off-by: Alex Hung <alex.hung at amd.com>

Reviewed-by: Andrzej Hajda <andrzej.hajda at intel.com>

Regards
Andrzej

> ---
>   tests/kms_plane.c | 9 ++++++---
>   1 file changed, 6 insertions(+), 3 deletions(-)
>
> diff --git a/tests/kms_plane.c b/tests/kms_plane.c
> index fc530d2c..164dacf4 100644
> --- a/tests/kms_plane.c
> +++ b/tests/kms_plane.c
> @@ -391,9 +391,12 @@ test_plane_panning(data_t *data, enum pipe pipe)
>   
>   	test_init(data, pipe);
>   
> -	for_each_memory_region(r, data->drm_fd)
> -		if (r->ci.memory_class == I915_MEMORY_CLASS_DEVICE)
> -			mem_size = r->cpu_size;
> +	if (is_i915_device(data->drm_fd)) {
> +		for_each_memory_region(r, data->drm_fd)
> +			if (r->ci.memory_class == I915_MEMORY_CLASS_DEVICE)
> +				mem_size = r->cpu_size;
> +
> +	}
>   
>   	for_each_connector_mode(output) {
>   		drmModeModeInfo *m = &output->config.connector->modes[j__];



More information about the igt-dev mailing list