[igt-dev] [PATCH i-g-t] tests/i915/gem_caching: Used XY_FAST_COPY_BLT for executing this on MTL

[Kumar, Sinjan]

Hi Vikas,

You can update the commit message like below, better not to use past tense for commit message description.

Like:- Enable XY_FAST_COPY_BLT for MTL platform.

Thanks & Regards,
Sinjan

> -----Original Message-----
> From: igt-dev <igt-dev-bounces at lists.freedesktop.org> On Behalf Of Vikas
> Srivastava
> Sent: Friday, November 25, 2022 3:12 PM
> To: igt-dev at lists.freedesktop.org
> Subject: [igt-dev] [PATCH i-g-t] tests/i915/gem_caching: Used
> XY_FAST_COPY_BLT for executing this on MTL
> 
> From: Arjun Melkaveri <arjun.melkaveri at intel.com>
> 
> Test case uses legacy command which is not supported on MTL.
> Modified test to use XY_FAST_COPY_BLT.
> 
> Cc: Prasad Nallani <prasad.nallani at intel.com>
> Cc: Telukuntla Sreedhar <sreedhar.telukuntla at intel.com>
> Signed-off-by: Arjun Melkaveri <arjun.melkaveri at intel.com>
> Signed-off-by: Vikas Srivastava <vikas.srivastava at intel.com>
> Acked-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/i915/gem_caching.c | 22 +++++++++++++---------
>  1 file changed, 13 insertions(+), 9 deletions(-)
> 
> diff --git a/tests/i915/gem_caching.c b/tests/i915/gem_caching.c index
> eb0170abc..a818a53c2 100644
> --- a/tests/i915/gem_caching.c
> +++ b/tests/i915/gem_caching.c
> @@ -82,15 +82,19 @@ copy_bo(struct intel_bb *ibb, struct intel_buf *src,
> struct intel_buf *dst)
>  	intel_bb_add_intel_buf(ibb, src, false);
>  	intel_bb_add_intel_buf(ibb, dst, true);
> 
> -	intel_bb_out(ibb,
> -		     XY_SRC_COPY_BLT_CMD |
> -		     XY_SRC_COPY_BLT_WRITE_ALPHA |
> -		     XY_SRC_COPY_BLT_WRITE_RGB |
> -		     (6 + 2 * has_64b_reloc));
> -
> -	intel_bb_out(ibb, (3 << 24) | /* 32 bits */
> -		     (0xcc << 16) | /* copy ROP */
> -		     4096);
> +	if (intel_graphics_ver(ibb->devid) >= IP_VER(12, 60)) {
> +		intel_bb_out(ibb, XY_FAST_COPY_BLT);
> +		intel_bb_out(ibb, XY_FAST_COPY_COLOR_DEPTH_32 | 4096);
> +	} else {
> +		intel_bb_out(ibb,
> +			     XY_SRC_COPY_BLT_CMD |
> +			     XY_SRC_COPY_BLT_WRITE_ALPHA |
> +			     XY_SRC_COPY_BLT_WRITE_RGB |
> +			     (6 + 2 * has_64b_reloc));
> +		intel_bb_out(ibb, (3 << 24) | /* 32 bits */
> +			     (0xcc << 16) | /* copy ROP */
> +			     4096);
> +	}
>  	intel_bb_out(ibb, 0 << 16 | 0);
>  	intel_bb_out(ibb, (BO_SIZE/4096) << 16 | 1024);
>  	intel_bb_emit_reloc_fenced(ibb, dst->handle,
> --
> 2.25.1