[igt-dev] [PATCH i-g-t v3 0/5] VC4 IGT Tests Updates

Melissa Wen mwen at igalia.com
Mon Dec 19 09:30:31 UTC 2022


On 12/16, Maíra Canal wrote:
> This series aims to update the VC4 IGT tests. The first three patches contain
> some janitorial duties related to the existing tests: creating a folder for the
> VC4 tests, removing some unused includes, and adding a macro with the default
> PAGE_SIZE. The fourth patch adds an igt_require to all the VC4 tests to
> check that the tests are not running on BCM2711. The final patch includes
> new tests for the VC4's performance monitors.
> 
> This series was tested on the Raspberry Pi 3 Model B and Raspberry Pi 4 Model B,
> and the HTML outputs of the VC4 tests are available on:
> 
> - Raspberry Pi 4: https://mairacanal.fedorapeople.org/igt-results/rpi4-v2/html/
> - Raspberry Pi 3: https://mairacanal.fedorapeople.org/igt-results/rpi3-v2/html/
> 

You already have the a-b from Petri.

And the series LGTM too:

Reviewed-by: Melissa Wen <mwen at igalia.com>

> Best Regards,
> - Maíra Canal
> 
> v1 -> v2:
> - Install VC4 tests on build/tests/vc4/ instead of build/tests/ (Melissa Wen).
> - Use the syncobj capability to identify vc4 and vc5 (Melissa Wen).
> - Change the order of the commits (Melissa Wen).
> - Add Petri Latvala tags.
> 
> v2 -> v3:
> - Remove ternary conditional operator from return (Petri Latvala).
> - Add Petri Latvala tag.
> 
> Maíra Canal (5):
>   tests/vc4: Move VC4 tests to their own folder
>   tests/vc4: Remove unused or redundant includes
>   lib/igt_vc4: Add PAGE_SIZE macro to VC4
>   tests/vc4: Skip VC4 tests if they are running on BCM2711/RaspberryPi4
>   tests/vc4_perfmon: Create test for VC4's Perfmon IOCTLs
> 
>  lib/igt_vc4.c                      |  60 ++++++++++---
>  lib/igt_vc4.h                      |   9 ++
>  meson.build                        |   8 ++
>  tests/meson.build                  |  10 +--
>  tests/vc4/meson.build              |  20 +++++
>  tests/{ => vc4}/vc4_create_bo.c    |  15 +---
>  tests/{ => vc4}/vc4_dmabuf_poll.c  |  14 +--
>  tests/{ => vc4}/vc4_label_bo.c     |  21 ++---
>  tests/{ => vc4}/vc4_lookup_fail.c  |  14 +--
>  tests/vc4/vc4_perfmon.c            | 138 +++++++++++++++++++++++++++++
>  tests/{ => vc4}/vc4_purgeable_bo.c |  10 ---
>  tests/{ => vc4}/vc4_tiling.c       |  27 ++----
>  tests/{ => vc4}/vc4_wait_bo.c      |  14 +--
>  tests/{ => vc4}/vc4_wait_seqno.c   |  15 +---
>  tests/vc4_ci/vc4.testlist          |  80 +++++++++--------
>  15 files changed, 298 insertions(+), 157 deletions(-)
>  create mode 100644 tests/vc4/meson.build
>  rename tests/{ => vc4}/vc4_create_bo.c (89%)
>  rename tests/{ => vc4}/vc4_dmabuf_poll.c (91%)
>  rename tests/{ => vc4}/vc4_label_bo.c (85%)
>  rename tests/{ => vc4}/vc4_lookup_fail.c (90%)
>  create mode 100644 tests/vc4/vc4_perfmon.c
>  rename tests/{ => vc4}/vc4_purgeable_bo.c (97%)
>  rename tests/{ => vc4}/vc4_tiling.c (88%)
>  rename tests/{ => vc4}/vc4_wait_bo.c (92%)
>  rename tests/{ => vc4}/vc4_wait_seqno.c (89%)
> 
> -- 
> 2.38.1
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <https://lists.freedesktop.org/archives/igt-dev/attachments/20221219/bc951cb9/attachment.sig>


More information about the igt-dev mailing list