[igt-dev] [PATCH i-g-t 2/2] lib/igt_fb: add an API to support color square DP CTS pattern

[Abhinav Kumar]

Hi Petri

Thanks for the comments and sorry for the late response.

Once Maitreyee left, this patch got abandoned.

I will take this over and address your comments.

Thanks

Abhinav

On 2/14/2022 5:46 PM, abhinavk at codeaurora.org wrote:
> 
> 
> -------- Original Message --------
> Subject: Re: [PATCH i-g-t 2/2] lib/igt_fb: add an API to support color 
> square DP CTS pattern
> Date: 2021-08-13 04:33
> From: Petri Latvala <petri.latvala at intel.com>
> To: maitreye <maitreye at codeaurora.org>
> Cc: igt-dev at lists.freedesktop.org, robdclark at gmail.com, 
> seanpaul at chromium.org, swboyd at chromium.org, nganji at codeaurora.org, 
> aravindh at codeaurora.org, abhinavk at codeaurora.org, khsieh at codeaurora.org, 
> manasi.d.navare at intel.com
> 
> On Wed, Aug 04, 2021 at 08:40:23PM -0700, maitreye wrote:
>> Add an api to support the CTA range color square video test
>> pattern as explained in section 3.2.5.3 of the DP CTS
>> specification. This pattern is required for supporting
>> the CTA range for RGB formats.
>>
>> Also rename the existing api igt_fill_cts_framebuffer to
>> igt_fill_cts_color_ramp_framebuffer to higlight the
>> pattern type.
>>
>> Signed-off-by: maitreye <maitreye at codeaurora.org>
> 
> Can you use your real name here?
> 
>> ---
>>  lib/igt_fb.c                | 125 
>> +++++++++++++++++++++++++++++++++++++++++++-
>>  lib/igt_fb.h                |   4 +-
>>  tools/intel_dp_compliance.c |   2 +-
>>  tools/msm_dp_compliance.c   |  43 +++++++++++----
>>  4 files changed, 160 insertions(+), 14 deletions(-)
>>
>> diff --git a/lib/igt_fb.c b/lib/igt_fb.c
>> index 583cc9e..3d34457 100644
>> --- a/lib/igt_fb.c
>> +++ b/lib/igt_fb.c
>> @@ -1396,7 +1396,128 @@ void igt_paint_color(cairo_t *cr, int x, int 
>> y, int w, int h,
>>  }
>>
>>  /**
>> - * igt_fill_cts_framebuffer:
>> + *
>> + * igt_fill_cts_color_square_framebuffer:
>> + * @pixmap: handle to mapped buffer
>> + * @video_width: required width for pattern
>> + * @video_height: required height for pattern
>> + * @bitdepth: required bitdepth fot pattern
>> + * @alpha: required alpha for the pattern
>> + *
>> + * This function draws a color square pattern for given width and height
>> + * as per the specifications mentioned in section 3.2.5.3 of DP CTS 
>> spec.
>> + */
>> +int igt_fill_cts_color_square_framebuffer(uint32_t *pixmap, uint32_t 
>> video_width,
>> +        uint32_t video_height, uint32_t bitdepth, int alpha)
>> +{
>> +    uint32_t max_color_val = 0;
>> +    uint32_t min_color_val = 0;
>> +    uint32_t* pmax = &max_color_val;
>> +    uint32_t* pmin = &min_color_val;
> 
> 
> I'm not fully understanding why these pointers are used?
> 
> 
>