[igt-dev] [PATCH i-g-t] tests/i915/gem_linear_blits: Added description to the subtest

[Kamil Konieczny]

Dnia 2022-02-15 at 10:42:36 +0530, sai.gowtham.ch at intel.com napisał(a):
> From: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> 
> Added description to subtests.
> 
> Cc: Melkaveri Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_linear_blits.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/i915/gem_linear_blits.c b/tests/i915/gem_linear_blits.c
> index 6504c9f2..b570aa76 100644
> --- a/tests/i915/gem_linear_blits.c
> +++ b/tests/i915/gem_linear_blits.c
> @@ -258,9 +258,13 @@ igt_main
>  		count = (count + ncpus - 1) / ncpus;
>  	}
>  
> +	igt_describe("Excercise 2 buffer objects check if driver will"
> +			"rearrange the buffers");

This is basic one, no rearrange will happen here, so better just:
	Basic blitter functionality check with only 2 buffers

Please compile your changes and check output with
./gem_linear_blitter --description
When you split text between lines, compiler will concatenate strings and there
will be something like:

check if driver willrearrange the buffers
No space here ------^

>  	igt_subtest("basic")
>  		run_test(fd, 2, do_relocs);
>  
> +	igt_describe("The intent is to push beyond the GTT size to force the driver"
> +			"to have to rearrange the buffers");
Space needed before "to" ^

You can add " [working] " word before "GTT size".

>  	igt_subtest("normal") {
>  		intel_allocator_multiprocess_start();
>  		igt_fork(child, ncpus)
> @@ -269,6 +273,8 @@ igt_main
>  		intel_allocator_multiprocess_stop();
>  	}
>  
> +	igt_describe("Pushes beyond the GTT size checks if driver will rearrange the"
> +			"buffers, with interrupts in between the parent process");

No need to repeat whole description here, simple "Test with interrupts in between".

>  	igt_subtest("interruptible") {
>  		intel_allocator_multiprocess_start();
>  		igt_fork_signal_helper();
> -- 
> 2.35.0
> 

Regards,
Kamil Konieczny