[igt-dev] [PATCH i-g-t] tests/i915/gem_ringfill: Added test description for test case.

[Kamil Konieczny]

Hi Sai,

Dnia 2022-02-15 at 10:53:47 +0530, sai.gowtham.ch at intel.com napisał(a):
> From: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> 
> Added test description to test and subtest.
> 
> Cc: Melkaveri Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_ringfill.c | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/tests/i915/gem_ringfill.c b/tests/i915/gem_ringfill.c
> index ecfa0bea..0d86141b 100644
> --- a/tests/i915/gem_ringfill.c
> +++ b/tests/i915/gem_ringfill.c
> @@ -51,6 +51,9 @@
>  #define HIBERNATE 0x40
>  #define NEWFD 0x80
>  
> +IGT_TEST_DESCRIPTION(" This test does many tiny batchbuffer operations to catch"

Remove space from beginning and try to avoid starting global
description with "This test does".  You can also reuse comment
from begginig of this test, it is:
 * This is a test of doing many tiny batchbuffer operations, in the hope of
 * catching failure to manage the ring properly near full.
so you can rephrase it like "Create many tiny ...".

> +		"errors while ring is near full.");
Space before "errors" needed.
Please compile and run with --describe to catch missing spaces.

> +
>  static unsigned int ring_size;
>  
>  static void check_bo(int fd, uint32_t handle)
> @@ -371,6 +374,9 @@ igt_main
>  		}
>  	}
>  
> +
> +	igt_describe("Test runs on all available engines simultaniously and"
> +			" checks how the driver handles a full ring.");
----------------------- ^
Please align under previous string.

Last question: may you describe also dynamic tests ?

>  	igt_subtest("basic-all") {
>  		const struct intel_execution_engine2 *e;
>  		intel_allocator_multiprocess_start();
> -- 
> 2.35.0
> 

Regards,
Kamil