[igt-dev] [PATCH i-g-t] tests/debugfs_test: Added test description for test case

Kamil Konieczny kamil.konieczny at linux.intel.com
Fri Feb 18 13:22:16 UTC 2022


Hi Priyanka,

Dnia 2022-02-15 at 19:53:04 +0530, priyanka.dandamudi at intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Added test description to all the available subtests.
> 
> v2:rebase
> 
> Cc: Katarzyna Dec <katarzyna.dec at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/debugfs_test.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
> index e6535ccd..0aa312dc 100644
> --- a/tests/debugfs_test.c
> +++ b/tests/debugfs_test.c
> @@ -29,6 +29,8 @@
>  #include <sys/types.h>
>  #include <dirent.h>
>  
> +IGT_TEST_DESCRIPTION("Test reads entries from debugfs and sysfs path.");
> +
s/Test reads/Read/
s/path/paths/

Please avoid starting description with "Test" or "This test".

>  static void read_and_discard_sysfs_entries(int path_fd, int indent)
>  {
>  	struct dirent *dirent;
> @@ -187,11 +189,13 @@ igt_main
>  		kmstest_set_vt_graphics_mode();
>  	}
>  
> +	igt_describe("Test reads all entries from sysfs path.");

s/Test reads/Read/

>  	igt_subtest("sysfs")
>  		read_and_discard_sysfs_entries(sysfs, 0);
> +	igt_describe("Test reads all entries from debugfs path.");

s/Test reads/Read/

>  	igt_subtest("read_all_entries")
>  		read_and_discard_sysfs_entries(debugfs, 0);
> -
> +	igt_describe("Test reads all debugfs entries with display on/off.");

s/Test reads/Read/

>  	igt_subtest_group
>  		kms_tests(fd, debugfs);
>  
> -- 
> 2.25.1
>

Regards,
Kamil
 


More information about the igt-dev mailing list