[igt-dev] [PATCH i-g-t, v2] i915/gem_exec_store: Add test description

[Kamil Konieczny]

Hi Apoorva,

Dnia 2022-02-16 at 12:59:15 +0530, apoorva1.singh at intel.com napisał(a):
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> Add description for test and all subtests
> 
> v2: Rebase
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> ---
>  tests/i915/gem_exec_store.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/tests/i915/gem_exec_store.c b/tests/i915/gem_exec_store.c
> index cb99f951..ef5f2b2c 100644
> --- a/tests/i915/gem_exec_store.c
> +++ b/tests/i915/gem_exec_store.c
> @@ -35,6 +35,8 @@
>  #include "igt_device.h"
>  #include "igt_gt.h"
>  
> +IGT_TEST_DESCRIPTION("Test the store functionality using execbuf-ioctl");
> +

s/Test/Exercise/
s/store/store dword/

>  #define ENGINE_MASK  (I915_EXEC_RING_MASK | I915_EXEC_BSD_MASK)
>  
>  /* Without alignment detection we assume the worst-case scenario. */
> @@ -432,15 +434,21 @@ igt_main
>  		igt_fork_hang_detector(fd);
>  	}
>  
> +	igt_describe("Verify that all engines can store dwords to a common buffer object");
>  	igt_subtest("basic")
>  		store_all(fd, ctx);

Note that there is check if engine is capable of dword store,
so please annotate this in description,

s/all engines/all capable engines/

>  
> +	igt_describe("Verify that each engine can store a dword to a buffer object");

s/each engine/each capable engine/

>  	test_each_engine("dword", fd, ctx, e)
>  		store_dword(fd, ctx, e);
>  
> +	igt_describe("Verify that each engine can store a dword to different cachelines "

s/each engine/each capable engine/

> +	       "of a buffer object");
>  	test_each_engine("cachelines", fd, ctx, e)
>  		store_cachelines(fd, ctx, e, 0);
>  
> +	igt_describe("Verify that each engine can store a dword to various page-sized "

s/each engine/each capable engine/

> +	       "buffer objects");
>  	test_each_engine("pages", fd, ctx, e)
>  		store_cachelines(fd, ctx, e, PAGES);
>  
> -- 
> 2.25.1
> 

Regards,
Kamil Konieczny