[igt-dev] [PATCH i-g-t , v2] i915/gem_create: Added test description for test case

[Kamil Konieczny]

Hi Priyanka,

Dnia 2022-02-16 at 18:05:08 +0530, priyanka.dandamudi at intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Added test description to all the available subtests.
> 
> v2: Added test description for newly added subtets.
> 
> Cc: Melkaveri, Arjun <Arjun.Melkaveri at intel.com>

Please write it without comma, so instead of "Melkaveri, Arjun"
write "Arjun Melkaveri".

> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/i915/gem_create.c | 14 ++++++++++++++
>  1 file changed, 14 insertions(+)
> 
> diff --git a/tests/i915/gem_create.c b/tests/i915/gem_create.c
> index 45804cde..0280fe31 100644
> --- a/tests/i915/gem_create.c
> +++ b/tests/i915/gem_create.c
> @@ -489,30 +489,44 @@ igt_main
>  		fd = drm_open_driver(DRIVER_INTEL);
>  	}
>  
> +	igt_describe("Test tries to create a gem object of invalid size 0"
> +		     " and checks if ioctl returns error.");

s/Test tries to create/Try to create/
s/checks/check/

>  	igt_subtest("create-invalid-size")
>  		invalid_size_test(fd);
>  
> +	igt_describe("Test tries to exercise impossible size of buffer object and "
> +		       "checks for the expected error.");

Replace "Test tries to exercise impossible size of buffer object and checks"
with
"Exercise creation of buffer object with impossible size and check"

Aline strings to be on same column.

>  	igt_subtest("create-massive")
>  		massive_test(fd);
>  
> +	igt_describe("Test creates an object with non-aligned size request "
> +		     "and assert the buffer is page aligned and tests the "
> +		     "write into the padded extra memory.");

"Try to create an object with non-aligned size,
 check we got one with size aligned up to page size
 and test we can write into the padded extra memory."

>  	igt_subtest("create-valid-nonaligned")
>  		valid_nonaligned_size(fd);
>  
> +	igt_describe("Test tries to create a gem object with size 15"
> +		     " and checks if the actual created size to be default page size.");

s/Test tries to create/Try to create/
s/checks if the actual created size to be default page size./check actual created size./

>  	igt_subtest("create-size-update")
>  		size_update(fd);
>  
> +	igt_describe("Test tries to verify that all new objects are clear.");

s/Test tries to verify/Verify/

>  	igt_subtest("create-clear")
>  		always_clear(fd, 30);
>  
> +	igt_describe("Test tries to create BO while GPU is busy.");

s/Test tries to create BO/Create buffer objects/

>  	igt_subtest("busy-create")
>  		busy_create(fd, 30);
>  
> +	igt_describe("Test tries to exercise create_ext placements extension");

s/Test tries to exercise/Exercise/

Add dot at end of description.

>  	igt_subtest("create-ext-placement-sanity-check")
>  		create_ext_placement_sanity_check(fd);
>  
> +	igt_describe("Test tries to create object in each memory region using create_ext.");

s/Test tries to create/Create/

>  	igt_subtest("create-ext-placement-each")
>  		create_ext_placement_each(fd);
>  
> +	igt_describe("Test tries to create object on all memory regions using create_ext.");

s/Test tries to create/Create/

>  	igt_subtest("create-ext-placement-all")
>  		create_ext_placement_all(fd);
>  
> -- 
> 2.25.1
> 

Also while you add new descriptions, please make main
description shorter, replace

IGT_TEST_DESCRIPTION("This is a test for the gem_create ioctl,"
		     " where the goal is to simply ensure that basics work"
		     " and invalid input combinations are rejected.");

with

IGT_TEST_DESCRIPTION("Ensure that basic gem_create and gem_create_ext works"
		     " and that invalid input combinations are rejected.");

Regards,
Kamil