[igt-dev] [PATCH i-g-t v4 01/16] lib/intel_device_info: Add a flag to indicate tiling 4 support

[Zbigniew Kempczyński]

On Fri, Feb 18, 2022 at 02:39:21PM +0530, Jeevan B wrote:
> From: Mika Kahola <mika.kahola at intel.com>
> 
> Add tiling 4 support flag for DG2 platform. This is similar that
> we have defined in kernel i915_pci.c intel_device_info() for DG2.
> 
> v2: rebase

This one looks ok but in long term keeping such data in intel_*_info 
structure can be problematic. Especially if for same hw some devid
can have different set of tilings supported (due to hw bug for example).

Anyway this is not blocker for the change:

Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

--
Zbigniew

> 
> Signed-off-by: Jeevan B <jeevan.b at intel.com>
> Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> Signed-off-by: Juha-Pekka Heikkilä <juha-pekka.heikkila at intel.com>
> ---
>  lib/intel_chipset.h     | 3 +++
>  lib/intel_device_info.c | 1 +
>  2 files changed, 4 insertions(+)
> 
> diff --git a/lib/intel_chipset.h b/lib/intel_chipset.h
> index e27b9aab..db75a829 100644
> --- a/lib/intel_chipset.h
> +++ b/lib/intel_chipset.h
> @@ -40,6 +40,7 @@ struct intel_device_info {
>  	unsigned graphics_ver;
>  	unsigned display_ver;
>  	unsigned gt; /* 0 if unknown */
> +	bool has_4tile : 1;
>  	bool has_flatccs;
>  	bool is_mobile : 1;
>  	bool is_whitney : 1;
> @@ -216,6 +217,8 @@ void intel_check_pch(void);
>  				   IS_CHERRYVIEW(devid) || \
>  				   IS_BROXTON(devid)))
>  
> +#define HAS_4TILE(devid)	(intel_get_device_info(devid)->has_4tile)
> +
>  #define HAS_FLATCCS(devid)	(intel_get_device_info(devid)->has_flatccs)
>  
>  #endif /* _INTEL_CHIPSET_H */
> diff --git a/lib/intel_device_info.c b/lib/intel_device_info.c
> index 9f191367..e55841df 100644
> --- a/lib/intel_device_info.c
> +++ b/lib/intel_device_info.c
> @@ -393,6 +393,7 @@ static const struct intel_device_info intel_dg1_info = {
>  static const struct intel_device_info intel_dg2_info = {
>  	.graphics_ver = 12,
>  	.display_ver = 13,
> +	.has_4tile = true,
>  	.is_dg2 = true,
>  	.codename = "dg2",
>  	.has_flatccs = true,
> -- 
> 2.17.1
>