[igt-dev] [PATCH i-g-t v2 2/2] test/perf_pmu: Change module unload assertion

Dixit, Ashutosh ashutosh.dixit at intel.com
Mon Feb 21 20:29:33 UTC 2022


On Mon, 21 Feb 2022 02:24:23 -0800, Anshuman Gupta wrote:
>
> diff --git a/tests/i915/perf_pmu.c b/tests/i915/perf_pmu.c
> index 4f3cb6145..a7f26c80f 100644
> --- a/tests/i915/perf_pmu.c
> +++ b/tests/i915/perf_pmu.c
> @@ -2101,7 +2101,7 @@ static void test_unload(unsigned int num_engines)
>
>		igt_debug("Read %d events from perf and trial unload\n", count);
>		pmu_read_multi(fd[0], count, buf);
> -		igt_assert_eq(__igt_i915_driver_unload(NULL), IGT_EXIT_SKIP);
> +		igt_assert_neq(__igt_i915_driver_unload(NULL), 0);

To be completely equivalent to IGT_EXIT_SKIP (before we broke it), I think
let us pass in a 'who' and make the condition: "ret != 0 && 'who' indicates
it is i915 which failed to unload".


More information about the igt-dev mailing list