[igt-dev] [PATCH i-g-t, v4] i915/gem_mmap: Added test description for test case

[Kamil Konieczny]

Hi Apoorva,

please ajust strings to begin on the same column, see below.

Dnia 2022-02-21 at 17:43:17 +0530, apoorva1.singh at intel.com napisał(a):
> From: Apoorva Singh <apoorva1.singh at intel.com>
> 
> Added test description to all the available subtests.

s/test description/tests descriptions/

Please use plural here, there was more than one added.

> 
> v2: Modified few descriptions to be more specific
> 
> v3: Rebase
> 
> v4: Incorporated minor changes as suggested in feedback
> 
> Signed-off-by: Apoorva Singh <apoorva1.singh at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Arjun Melkaveri <arjun.melkaveri at intel.com>
> ---
>  tests/i915/gem_mmap.c | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/tests/i915/gem_mmap.c b/tests/i915/gem_mmap.c
> index 61c9c5c1..9d72727b 100644
> --- a/tests/i915/gem_mmap.c
> +++ b/tests/i915/gem_mmap.c
> @@ -39,6 +39,8 @@
>  #include "drm.h"
>  #include "i915/gem_create.h"
>  
> +IGT_TEST_DESCRIPTION("Basic MMAP IOCTL tests for memory regions.");
> +
>  #define OBJECT_SIZE 16384
>  #define PAGE_SIZE 4096
>  int fd;
> @@ -161,6 +163,7 @@ igt_main
>  		igt_require(gem_has_legacy_mmap(fd));
>  	}
>  
> +	igt_describe("Verify mapping to invalid gem objects won't be created.");
>  	igt_subtest("bad-object") {
>  		uint32_t real_handle = gem_create(fd, 4096);
>  		uint32_t handles[20];
> @@ -185,6 +188,7 @@ igt_main
>  		gem_close(fd, real_handle);
>  	}
>  
> +	igt_describe("Verify mapping to gem object with invalid offset won't be created.");
>  	igt_subtest("bad-offset") {
>  		struct bad_offset {
>  			uint64_t size;
> @@ -212,6 +216,7 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Verify mapping to gem object with invalid size won't be created.");
>  	igt_subtest("bad-size") {
>  		uint64_t bad_size[] = {
>  			0,
> @@ -242,6 +247,8 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Test basics of newly mapped gem object like default content, write and read "
---------------------^
> +	       "coherency, mapping existence after gem_close and unmapping.");
---------------------^

This should look like:

+	igt_describe("Test basics of newly mapped gem object like default content, write and read "
+		     "coherency, mapping existence after gem_close and unmapping.");

Please use tabs, then spaces. Please do the same edit in
following lines.

>  	igt_subtest("basic") {
>  		struct drm_i915_gem_mmap arg = {
>  			.handle = gem_create(fd, OBJECT_SIZE),
> @@ -269,6 +276,7 @@ igt_main
>  		munmap(addr, OBJECT_SIZE);
>  	}
>  
> +	igt_describe("Map small buffer object though direct CPU access, bypassing GPU.");
>  	igt_subtest("short-mmap") {
>  		uint32_t handle = gem_create(fd, OBJECT_SIZE);
>  
> @@ -281,15 +289,28 @@ igt_main
>  		gem_close(fd, handle);
>  	}
>  
> +	igt_describe("Verify that GTT page faults are asynchronous to GPU rendering and "
> +	       "completes within a specific time.");

adjust here

>  	igt_subtest("pf-nonblock")
>  		test_pf_nonblock(fd);
>  
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "of a small buffer object.");

adjust here

>  	igt_subtest("basic-small-bo")
>  		test_huge_bo(-1);
> +
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "of a big buffer object.");

adjust here

>  	igt_subtest("big-bo")
>  		test_huge_bo(0);
> +
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "of a huge buffer object.");

adjust here

>  	igt_subtest("huge-bo")
>  		test_huge_bo(1);
> +
> +	igt_describe("Test the write read coherency and simultaneous access of different pages "
> +	       "while swapping buffer object.");

adjust here

>  	igt_subtest("swap-bo")
>  		test_huge_bo(2);
>  
> -- 
> 2.25.1
> 
With that fixed, you can add my r-b.

Regards,
Kamil