[igt-dev] [PATCH i-g-t, v3] tests/debugfs_test: Added test description for test case

Kamil Konieczny kamil.konieczny at linux.intel.com
Tue Feb 22 14:55:13 UTC 2022


Hi Priyanka,
 
Dnia 2022-02-22 at 18:15:36 +0530, priyanka.dandamudi at intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Added test description to all the available subtests.
> 
> v2: rebase
> 
> v3: Updated test descriptions.
> 
> Cc: Melkaveri Arjun <Arjun.Melkaveri at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
>  tests/debugfs_test.c | 6 +++++-
>  1 file changed, 5 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/debugfs_test.c b/tests/debugfs_test.c
> index e6535ccd..deb58f10 100644
> --- a/tests/debugfs_test.c
> +++ b/tests/debugfs_test.c
> @@ -29,6 +29,8 @@
>  #include <sys/types.h>
>  #include <dirent.h>
>  
> +IGT_TEST_DESCRIPTION("Read entries from debugfs and sysfs paths.");
> +
>  static void read_and_discard_sysfs_entries(int path_fd, int indent)
>  {
>  	struct dirent *dirent;
> @@ -187,11 +189,13 @@ igt_main
>  		kmstest_set_vt_graphics_mode();
>  	}
>  
> +	igt_describe("Read all entries from sysfs path.");
>  	igt_subtest("sysfs")
>  		read_and_discard_sysfs_entries(sysfs, 0);
> +	igt_describe("Read all entries from debugfs path.");
>  	igt_subtest("read_all_entries")
>  		read_and_discard_sysfs_entries(debugfs, 0);
> -

Please keep this newline here, it separates tests from subtets group.

> +	igt_describe("Read all debugfs entries with display on/off.");
>  	igt_subtest_group
>  		kms_tests(fd, debugfs);
>  
> -- 
> 2.25.1
>
With that fixed you can add my r-b.

Regards,
Kamil
 


More information about the igt-dev mailing list