[igt-dev] [PATCH i-g-t 1/2] lib/igt_dummyload: Save spin->opts as part of the spinner

Dixit, Ashutosh ashutosh.dixit at intel.com
Tue Feb 22 19:49:17 UTC 2022


On Fri, 18 Feb 2022 17:32:14 -0800, Jasmine Newsome wrote:
>
> Save igt_spin_factory info in igt_spin. This will allow
> for access to the actual context within the spinner.
> Previously, only the context id was accessible.

Not sure about the sentence above, not seeing context id as part of
igt_spin_t. Maybe just drop this sentence.

> This might help make spinner code cleaner.

Maybe we can just say something like: Save the opts with which the spin was
created as part of the spin so that the opts are available in case they are
needed. Something like that.

The patch itself is fine, just the commit message needs a tweak. Thanks.


More information about the igt-dev mailing list