[igt-dev] [PATCH 1/1] tests/i915/kms_frontbuffer_tracking: ignore case when checking DRRS support

Souza, Jose jose.souza at intel.com
Wed Feb 23 18:35:50 UTC 2022


On Wed, 2022-02-23 at 10:18 -0800, James Xiong wrote:
> i915 commit caab25dc9e36 switched to yesno macro and changed

commit caab25dc9e36 ("drm/i915/display: Fix DRRS debugfs")

> i915_drrs_status from "DRRS Supported: Yes" to "yes". ignore case
> when checking if drrs is supported to avoid false result.

Patch is good but could you please re-send it with the fix above and your "Signed-off-by:" line?

> ---
>  tests/i915/kms_frontbuffer_tracking.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/i915/kms_frontbuffer_tracking.c b/tests/i915/kms_frontbuffer_tracking.c
> index 532bfbb9..329375b0 100644
> --- a/tests/i915/kms_frontbuffer_tracking.c
> +++ b/tests/i915/kms_frontbuffer_tracking.c
> @@ -795,7 +795,7 @@ static bool is_drrs_supported(void)
>  	char buf[MAX_DRRS_STATUS_BUF_LEN];
>  
>  	debugfs_read("i915_drrs_status", buf);
> -	return strstr(buf, "DRRS Supported: Yes");
> +	return strcasestr(buf, "DRRS Supported: Yes");
>  }
>  
>  static bool is_drrs_inactive(void)



More information about the igt-dev mailing list