[igt-dev] [PATCH i-g-t 1/2] lib/intel_allocator: Add safe alignment as a default

Zbigniew Kempczyński zbigniew.kempczynski at intel.com
Thu Feb 24 07:49:01 UTC 2022


On Wed, Feb 23, 2022 at 10:45:07PM -0800, Dixit, Ashutosh wrote:
> On Wed, 23 Feb 2022 02:33:02 -0800, Zbigniew Kempczyński wrote:
> >
> > diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c
> > index e5666cd4f..ddb8d8c1f 100644
> > --- a/lib/intel_batchbuffer.c
> > +++ b/lib/intel_batchbuffer.c
> > @@ -1360,7 +1360,7 @@ __intel_bb_create(int i915, uint32_t ctx, uint32_t size, bool do_relocs,
> >		ibb->allocator_handle = intel_allocator_open_full(i915, ctx,
> >								  start, end,
> >								  allocator_type,
> > -								  strategy);
> > +								  strategy, 0);
> 
> Still reviewing but do we need to change ibb->alignment just below? Also
> alignment in intel_bb_add_object()?

Yes, I wanted to add this as separate change. I'm not able to run
this on CI so I introduce changes partially.

But I got changes in intel-bb scheduled after above will be merged.
--
Zbigniew


More information about the igt-dev mailing list