[igt-dev] [PATCH i-g-t] lib/igt_dummyload: Drop ahnd from igt_spin_t

Dixit, Ashutosh ashutosh.dixit at intel.com
Fri Feb 25 22:18:21 UTC 2022


On Fri, 25 Feb 2022 03:29:59 -0800, Zbigniew Kempczyński wrote:
>
> On Thu, Feb 24, 2022 at 02:02:29PM -0800, Ashutosh Dixit wrote:
> > In 4d9396e67930 we have started storing the opts with which the spin was
> > created as part of igt_spin_t. The ahnd stored as part of igt_spin_t is
> > therefore redundant. We can get ahnd from opts.ahnd.
>
> More than redundancy I like to keep opts which comes from the caller
> and thus suggests spinner code that's immune. Unfortunatelly we cannot
> block this after memcmp using c-syntax (I'm not able to do this).

Sorry, didn't follow what you are referring to here?

> Anyway, keeping caller vars in opts suggests this so:
>
> Reviewed-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>

Thanks, but will wait for your reply before merging.


More information about the igt-dev mailing list