[igt-dev] [PATCH i-g-t v2] Add an api to support the CTA range color square video test pattern as explained in section 3.2.5.3 of the DP CTS specification. This pattern is required for supporting the CTA range for RGB formats.

Abhinav Kumar quic_abhinavk at quicinc.com
Sat Feb 26 03:16:04 UTC 2022


Hi Petri

On 2/21/2022 2:13 AM, Petri Latvala wrote:
> On Wed, Feb 16, 2022 at 03:03:42PM -0800, Abhinav Kumar wrote:
>> From: Maitreyee Rao <maitreye at codeaurora.org>
>>
>> Also rename the existing api igt_fill_cts_framebuffer to
>> igt_fill_cts_color_ramp_framebuffer to higlight the
>> pattern type.
>>
>> changes in v2:
>> 	- removed redundant pointers
>> 	- fixed overall formatting issues
>> 	- Fixed author name
>>
>> Signed-off-by: Maitreyee Rao <maitreye at codeaurora.org>
>> Signed-off-by: Abhinav Kumar <quic_abhinavk at quicinc.com>
> 
> 
> ../lib/igt_fb.c: In function ‘igt_fill_cts_color_square_framebuffer’:
> ../lib/igt_fb.c:1515:2: warning: ISO C90 forbids mixed declarations and code [-Wdeclaration-after-statement]
>   1515 |  uint32_t colors[8][3] = {
>        |  ^~~~~~~~
> ../lib/igt_fb.c:1555:19: warning: initialization of ‘uint8_t *’ {aka ‘unsigned char *’} from incompatible pointer type ‘uint32_t *’ {aka ‘unsigned int *’} [-Wincompatible-pointer-types]
>   1555 |   uint8_t *temp = pixmap;
>        |                   ^~~~~~
> 
> 
> 

I have addressed these and pushed 
https://patchwork.freedesktop.org/patch/476306/.

Somehow the chrome compiler didnt catch these.

Thanks

Abhinav



More information about the igt-dev mailing list