[igt-dev] [PATCH i-g-t] tests/i915/gem_ctx_exec: Skip test for RCS+CCS

[Dandamudi, Priyanka]

-----Original Message-----
From: Dandamudi, Priyanka 
Sent: 05 January 2022 11:32 AM
To: Harrison, John C <john.c.harrison at intel.com>; igt-dev at lists.freedesktop.org; Melkaveri, Arjun <Arjun.Melkaveri at intel.com>; Dixit, Ashutosh <ashutosh.dixit at intel.com>; Gupta, saurabhg <saurabhg.gupta at intel.com>
Subject: RE: [PATCH i-g-t] tests/i915/gem_ctx_exec: Skip test for RCS+CCS



-----Original Message-----
From: Harrison, John C <john.c.harrison at intel.com>
Sent: 05 January 2022 01:13 AM
To: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; igt-dev at lists.freedesktop.org; Melkaveri, Arjun <arjun.melkaveri at intel.com>; Dixit, Ashutosh <ashutosh.dixit at intel.com>; Gupta, saurabhg <saurabhg.gupta at intel.com>
Subject: Re: [PATCH i-g-t] tests/i915/gem_ctx_exec: Skip test for RCS+CCS

On 12/28/2021 23:52, priyanka.dandamudi at intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
>
> Updated the nohangcheck test to skip for DG2 as test fails when reset 
> is applied for the RCS+CCS combination.
>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> Cc: John Harrison <John.C.Harrison at Intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> ---
>   tests/i915/gem_ctx_exec.c | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
>
> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c 
> index a1270a88..dbb46404 100644
> --- a/tests/i915/gem_ctx_exec.c
> +++ b/tests/i915/gem_ctx_exec.c
> @@ -276,6 +276,9 @@ static void nohangcheck_hostile(int i915)
>   	int err = 0;
>   	int dir;
>   	uint64_t ahnd;
> +	bool rcs_found = false;
> +	bool ccs_found = false;
> +
>   
>   	/*
>   	 * Even if the user disables hangcheck during their context, @@
> -293,6 +296,17 @@ static void nohangcheck_hostile(int i915)
>   
>   	igt_require(__enable_hangcheck(dir, false));
>   
> +	for_each_ctx_engine(i915, ctx, e) {
> +		if(rcs_found && ccs_found)
> +			break;
> +		else if(e->class == I915_ENGINE_CLASS_RENDER && rcs_found == false){
> +			rcs_found = true;
> +			continue;
> +		}
> +		else if(e->class == I915_ENGINE_CLASS_COMPUTE && ccs_found == false)
> +			ccs_found = true;
> +	}
> +	igt_require(!(rcs_found && ccs_found));
This is not the right approach.

As per the commit description above, the problem is for DG2 and DG2 alone. The skip condition should be simply 'if(IS_DG2)'. There is no need to detect RCS and CCS presence.

John.

Will change the commit description to all platforms, as the flag set in this subtest is no_preemption and test should skip for all platforms not only DG2. To skip for DG2 platform need to upstream libs as it is not present as of now.

Priyanka

>   	for_each_ctx_engine(i915, ctx, e) {
>   		igt_spin_t *spin;
>   		int new;