[igt-dev] [PATCH i-g-t v2 2/2] tests/i915/gem_ctx_exec: Skip test for shared reset domain

Matt Roper matthew.d.roper at intel.com
Thu Jan 13 22:17:09 UTC 2022


On Mon, Jan 10, 2022 at 11:41:41AM +0530, priyanka.dandamudi at intel.com wrote:
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> The test tries to submit non-preemptible spinneris to all engines,
> causes a hang and expects the non-preemptible spinners to survive
> but fails to do for RCS+CCS.
> So, updated the code to skip nohangcheck subtest for a platform with RCS+CCS.
> 
> v2: Some minor fixes (Ashutosh).
> 
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> Cc: John Harrison <John.C.Harrison at Intel.com>
> Cc: Melkaveri, Arjun <arjun.melkaveri at intel.com>
> ---
>  tests/i915/gem_ctx_exec.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/tests/i915/gem_ctx_exec.c b/tests/i915/gem_ctx_exec.c
> index a1270a88..4c21542d 100644
> --- a/tests/i915/gem_ctx_exec.c
> +++ b/tests/i915/gem_ctx_exec.c
> @@ -292,6 +292,7 @@ static void nohangcheck_hostile(int i915)
>  	ahnd = get_reloc_ahnd(i915, ctx->id);
>  
>  	igt_require(__enable_hangcheck(dir, false));
> +	igt_require(!has_shared_reset_domain(i915, ctx));

RCS and CCS engines share a reset domain, but all of the other engines
(bcs, vcs, vecs) should still reset independently.  Shouldn't we still
test that the other engines are not impacted (and conversely that they
do not impact the RCS/CCS engines)?


Matt

>  
>  	for_each_ctx_engine(i915, ctx, e) {
>  		igt_spin_t *spin;
> -- 
> 2.25.1
> 

-- 
Matt Roper
Graphics Software Engineer
VTT-OSGC Platform Enablement
Intel Corporation
(916) 356-2795


More information about the igt-dev mailing list