[igt-dev] [PATCH i-g-t] kms_psr2_su: Fix igt_fixture handling
Souza, Jose
jose.souza at intel.com
Mon Jan 17 13:37:42 UTC 2022
On Mon, 2022-01-17 at 15:32 +0200, Jouni Högander wrote:
> Igt_fixture is in a loop for different operations. This is causing
> display_fini being called at the end of each iteration and
> triggering SIGSEGV. Fix this by removing igt_fixture out from
> the loop.
>
> Fixes: 6be8feeb148e (tests/kms_psr2_su: add biplanar selective update tests)
Should be:
Fixes: 6be8feeb148e ("tests/kms_psr2_su: add biplanar selective update tests")
And if you want to CC people you should add:
Cc: Petri Latvala <petri.latvala at intel.com>
Cc: José Roberto de Souza <jose.souza at intel.com>
Other than above the patch lgtm.
Reviewed-by: José Roberto de Souza <jose.souza at intel.com>
> Signed-off-by: Jouni Högander <jouni.hogander at intel.com>
> ---
> tests/i915/kms_psr2_su.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/tests/i915/kms_psr2_su.c b/tests/i915/kms_psr2_su.c
> index d79a1e58..474b1dfd 100644
> --- a/tests/i915/kms_psr2_su.c
> +++ b/tests/i915/kms_psr2_su.c
> @@ -327,10 +327,9 @@ igt_main
> cleanup(&data);
> }
> }
> -
> - igt_fixture {
> - close(data.debugfs_fd);
> - display_fini(&data);
> - }
> + }
> + igt_fixture {
> + close(data.debugfs_fd);
> + display_fini(&data);
> }
> }
More information about the igt-dev
mailing list