[igt-dev] [PATCH i-g-t 3/4] tests/kms_cursor_crc: Fix -Wformat-truncation

[Ville Syrjälä]

On Fri, Jul 01, 2022 at 08:05:36PM -0700, Ashutosh Dixit wrote:
> [72/1181] Compiling C object tests/kms_cursor_crc.p/kms_cursor_crc.c.o
> ../tests/kms_cursor_crc.c: In function ‘run_size_tests.constprop’:
> ../tests/kms_cursor_crc.c:702:50: warning: ‘%d’ directive output may be truncated writing between 1 and 11 bytes into a region of size between 4 and 14 [-Wformat-truncation=]
>   702 |                 snprintf(name, sizeof(name), "%dx%d", w, h);
>       |                                                  ^~
> ../tests/kms_cursor_crc.c:702:46: note: directive argument in the range [-2147483648, 1024]
>   702 |                 snprintf(name, sizeof(name), "%dx%d", w, h);
>       |                                              ^~~~~~~

Weird that it almost managed to figure out the upper limit
(just off by ^2 for some reason) but totally failed at the lower
limit.

Anyways, series is
Reviewed-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

> 
> Signed-off-by: Ashutosh Dixit <ashutosh.dixit at intel.com>
> ---
>  tests/kms_cursor_crc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 5c90537b2337..588063555c67 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -693,7 +693,7 @@ static void test_rapid_movement(data_t *data)
>  static void run_size_tests(data_t *data, void (*testfunc)(data_t *),
>  			   int w, int h)
>  {
> -	char name[16];
> +	char name[32];
>  	enum pipe pipe;
>  
>  	if (w == 0 && h == 0)
> -- 
> 2.34.1

-- 
Ville Syrjälä
Intel