[igt-dev] [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9

Gupta, Anshuman anshuman.gupta at intel.com
Mon Jul 11 04:11:00 UTC 2022



> -----Original Message-----
> From: Srivatsa, Anusha <anusha.srivatsa at intel.com>
> Sent: Friday, July 8, 2022 11:48 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Srivatsa, Anusha <anusha.srivatsa at intel.com>; Deak, Imre
> <imre.deak at intel.com>; Gupta, Anshuman <anshuman.gupta at intel.com>; Vivi,
> Rodrigo <rodrigo.vivi at intel.com>
> Subject: [i-g-t] tests/i915/i915_pm_dc: Remove PC8+ dependency from DC9
> 
> Different from DC6, DC9 does not depend on BIOS/PCU to execute save and
> restore or any other sequence when going to PC9/PC10
Commit message should explain this is a change for all DGFX platform.
Thanks,
Anshuman Gupta.
> 
> DC9 actually depends on D3 and PCODE simply remove power if SW allowed
> 
> v2: resrict the check for igfx only.
> 
> Cc: Imre Deak <imre.deak at intel.com>
> Cc: Anshuman Gupta <anshuman.gupta at intel.com>
> Cc: Anusha Srivatsa <anusha.srivatsa at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Signed-off-by: Anusha Srivatsa <anusha.srivatsa at intel.com>(v2)
> ---
>  tests/i915/i915_pm_dc.c | 5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c index
> a780f2cb..5132734b 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -532,8 +532,9 @@ int main(int argc, char *argv[])
> 
>  	igt_describe("This test validates display engine entry to DC9 state");
>  	igt_subtest("dc9-dpms") {
> -
> 	igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> -				"PC8+ residencies not supported\n");
> +		if (!(IS_DG1(data.devid) || IS_DG2(data.devid)))
> +
> 	igt_require_f(igt_pm_pc8_plus_residencies_enabled(data.msr_fd),
> +				      "PC8+ residencies not supported\n");
>  		test_dc9_dpms(&data);
>  	}
> 
> --
> 2.25.1



More information about the igt-dev mailing list