[igt-dev] [PATCH i-g-t] tests/kms_cursor_crc: Move output check to the beginning

[Sharma, Swati2]

LGTM
Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>


On 06-Jul-22 2:27 PM, Karthik B S wrote:
> This test is failing on headless configurations as the check to verify
> if the output is present is at the end of the fixture after other checks.
> Move output check to the beginning of the fixture to avoid this failure
> and skip the test gracefully.
> 
> Signed-off-by: Karthik B S <karthik.b.s at intel.com>
> ---
>   tests/kms_cursor_crc.c | 6 +++---
>   1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/tests/kms_cursor_crc.c b/tests/kms_cursor_crc.c
> index 5c90537b..51bd3c8e 100644
> --- a/tests/kms_cursor_crc.c
> +++ b/tests/kms_cursor_crc.c
> @@ -873,6 +873,9 @@ igt_main
>   	igt_fixture {
>   		data.drm_fd = drm_open_driver_master(DRIVER_ANY);
>   
> +		igt_display_require(&data.display, data.drm_fd);
> +		igt_display_require_output(&data.display);
> +
>   		ret = drmGetCap(data.drm_fd, DRM_CAP_CURSOR_WIDTH, &cursor_width);
>   		igt_assert(ret == 0 || errno == EINVAL);
>   		/* Not making use of cursor_height since it is same as width, still reading */
> @@ -882,9 +885,6 @@ igt_main
>   		kmstest_set_vt_graphics_mode();
>   
>   		igt_require_pipe_crc(data.drm_fd);
> -
> -		igt_display_require(&data.display, data.drm_fd);
> -		igt_display_require_output(&data.display);
>   	}
>   
>   	data.cursor_max_w = cursor_width;

-- 
~Swati Sharma