[igt-dev] [PATCH i-g-t] lib/igt_gt: Remove static vcs2 engine

[Das, Nirmoy]

On 7/11/2022 9:00 AM, Zbigniew Kempczyński wrote:
> Keeping this entry with flags == -1 doesn't make sense. Batchbuffers
> executed with such invalid flags will always return -EINVAL.


Sounds good to me.

Reviewed-by: Nirmoy Das <nirmoy.das at intel.com>

>
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6393
>
> In above reference entering iteration on static engines is the result
> of fault in the driver (effect of previous fault-injection test).
> As we know passing invalid flags is wrong lets get rid off this entry
> from the static engine list.
>
> Signed-off-by: Zbigniew Kempczyński <zbigniew.kempczynski at intel.com>
> Cc: Ashutosh Dixit <ashutosh.dixit at intel.com>
> Cc: Petri Latvala <petri.latvala at intel.com>
> ---
>   lib/igt_gt.c | 1 -
>   1 file changed, 1 deletion(-)
>
> diff --git a/lib/igt_gt.c b/lib/igt_gt.c
> index 50da512f21..d4a825e664 100644
> --- a/lib/igt_gt.c
> +++ b/lib/igt_gt.c
> @@ -616,7 +616,6 @@ const struct intel_execution_engine2 intel_execution_engines2[] = {
>   	{ "bcs0", I915_ENGINE_CLASS_COPY, 0, I915_EXEC_BLT },
>   	{ "vcs0", I915_ENGINE_CLASS_VIDEO, 0, I915_EXEC_BSD | I915_EXEC_BSD_RING1 },
>   	{ "vcs1", I915_ENGINE_CLASS_VIDEO, 1, I915_EXEC_BSD | I915_EXEC_BSD_RING2 },
> -	{ "vcs2", I915_ENGINE_CLASS_VIDEO, 2, -1 },
>   	{ "vecs0", I915_ENGINE_CLASS_VIDEO_ENHANCE, 0, I915_EXEC_VEBOX },
>   	{ }
>   };