[igt-dev] [PATCH i-g-t 2/2] tests/gem_exec_fence: Coordinate sleep with the start of the request

[Karolina Drobnik]

Hi Kamil,

On 22.07.2022 15:41, Kamil Konieczny wrote:
> Hi,
> 
> On 2022-07-20 at 16:01:04 +0200, Karolina Drobnik wrote:
>> From: Chris Wilson <chris at chris-wilson.co.uk>
>>
>> Wait until we know the request is running on the GPU before sleeping
>> and giving a chance for other fences to run ahead.
>>
>> Signed-off-by: Chris Wilson <chris at chris-wilson.co.uk>
>> Signed-off-by: Karolina Drobnik <karolina.drobnik at intel.com>
>> ---
>>   tests/i915/gem_exec_fence.c | 6 +++++-
>>   1 file changed, 5 insertions(+), 1 deletion(-)
>>
>> diff --git a/tests/i915/gem_exec_fence.c b/tests/i915/gem_exec_fence.c
>> index c1bd2a38..5f15fbdd 100644
>> --- a/tests/i915/gem_exec_fence.c
>> +++ b/tests/i915/gem_exec_fence.c
>> @@ -324,7 +324,10 @@ static void test_fence_await(int fd, const intel_ctx_t *ctx,
>>   			    .ahnd = ahnd,
>>   			    .ctx = ctx,
>>   			    .engine = e->flags,
>> -			    .flags = IGT_SPIN_FENCE_OUT | spin_hang(flags));
>> +			    .flags =
>> +			    IGT_SPIN_FENCE_OUT |
>> +			    IGT_SPIN_POLL_RUN |
>> +			    spin_hang(flags));
> 
> Please move these after '=', so it will be
> 			    .flags = IGT_SPIN_FENCE_OUT | IGT_SPIN_POLL_RUN |
> 			             spin_hang(flags));

I think it's more of a style preference - the author decided to go for 
it, and it looks good to me. But if you have a specific style guidance 
that points out that such formatting is undesirable, please share and 
I'll correct the patch.

Many thanks,
Karolina

> With that fixed,
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> 
> --
> Kamil
> 
>>   	igt_assert(spin->out_fence != -1);
>>   
>>   	i = 0;
>> @@ -347,6 +350,7 @@ static void test_fence_await(int fd, const intel_ctx_t *ctx,
>>   		i++;
>>   	}
>>   
>> +	igt_spin_busywait_until_started(spin);
>>   	/* Long, but not too long to anger preemption disable checks */
>>   	usleep(50 * 1000); /* 50 ms, typical preempt reset is 150+ms */
>>   
>> -- 
>> 2.25.1
>>