[igt-dev] [PATCH i-g-t v4 1/3] lib/igt_kms: Add helper to parse mode string

[Rohith Iyer]

Hi Petri,

On 7/29/2022 3:02 AM, Petri Latvala wrote:
> On Thu, Jul 28, 2022 at 04:20:31PM -0700, Rohith Iyer wrote:
>> Add helper method to parse a mode string and verify
>> correct number of arguments. This standardizes parsing mode strings.
>>
>> Changes made in V4:
>>   - Corrected documentation
>>   - Changed *mode_string to a const char from char
>>
>> Signed-off-by: Rohith Iyer <quic_rohiiyer at quicinc.com>
>> ---
>>   lib/igt_kms.c | 26 ++++++++++++++++++++++++++
>>   lib/igt_kms.h |  1 +
>>   2 files changed, 27 insertions(+)
>>
>> diff --git a/lib/igt_kms.c b/lib/igt_kms.c
>> index 14064614..c17c10ea 100644
>> --- a/lib/igt_kms.c
>> +++ b/lib/igt_kms.c
>> @@ -5777,3 +5777,29 @@ bool igt_check_bigjoiner_support(igt_display_t *display)
>>   
>>   	return true;
>>   }
>> +
>> +/**
>> + * igt_parse_mode_string:
>> + * @mode_string: modeline string
>> + * @mode: a pointer to a drm mode structure
>> + *
>> + * Parse mode string and populate mode
>> + *
>> + * Format: <clock(MHz)>,<hdisp>,<hsync-start>,<hsync-end>,<htotal>,<vdisp>,<vsync-start>,
>> + * <vsync-end>,<vtotal>
> 
> Building docs breaks with this series, because of these <>s afaics. Make this just
> 
> * Format: clock(MHz),hdisp,hsync-start,hsync-end,htotal,vdisp,vsync-start,vsync-end,vtotal
> 
> 
> 

The change has been made in V5, now there are no errors in builddoc.

Thanks,
Rohith