[igt-dev] [1/2] tests/i915/gem_render_tiled_blits : Added subtests description

[Kamil Konieczny]

Hi Janga,

please rebase and send again, you can keep r-b tag.

Regards,
Kamil

On 2022-06-01 at 02:41:35 +0530, janga.rahul.kumar at intel.com wrote:
> From: "Kumar, Janga Rahul" <janga.rahul.kumar at intel.com>
> 
> Added test description to all the available subtests and
> fix file name in the file description comments.
> 
> v2: Fix syntax issues.
> v3: Modified subtest description.
> 
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Cc: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> Signed-off-by: Janga Rahul Kumar <janga.rahul.kumar at intel.com>
> Reviewed-by: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> ---
>  tests/i915/gem_render_tiled_blits.c | 12 +++++++++++-
>  1 file changed, 11 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_render_tiled_blits.c b/tests/i915/gem_render_tiled_blits.c
> index 187714d6..5ccb195e 100644
> --- a/tests/i915/gem_render_tiled_blits.c
> +++ b/tests/i915/gem_render_tiled_blits.c
> @@ -25,7 +25,7 @@
>   *
>   */
>  
> -/** @file gem_linear_render_blits.c
> +/** @file gem_render_tiled_blits.c
>   *
>   * This is a test of doing many blits, with a working set
>   * larger than the aperture size.
> @@ -49,6 +49,10 @@
>  #include "i915/gem.h"
>  #include "igt.h"
>  
> +IGT_TEST_DESCRIPTION("Tests performs cyclic forward, backward and random blits on tiled buffer "
> +		      "objects using render engine with various working set sizes and compares "
> +		      "outputs with expected ones.");
> +
>  #define WIDTH 512
>  #define STRIDE (WIDTH*4)
>  #define HEIGHT 512
> @@ -205,16 +209,20 @@ igt_main
>  		igt_require(gem_available_fences(fd) > 0);
>  	}
>  
> +	igt_describe("Check basic functionality.");
>  	igt_subtest("basic") {
>  		run_test(fd, 2);
>  	}
>  
> +	igt_describe("Check with working set size larger than aperture size.");
>  	igt_subtest("aperture-thrash") {
>  		count = 3 * gem_aperture_size(fd) / SIZE / 2;
>  		intel_require_memory(count, SIZE, CHECK_RAM);
>  		run_test(fd, count);
>  	}
>  
> +	igt_describe("Check with working set size larger than aperture size and "
> +		     "a helper process to shrink buffer object caches.");
>  	igt_subtest("aperture-shrink") {
>  		igt_fork_shrink_helper(fd);
>  
> @@ -225,6 +233,8 @@ igt_main
>  		igt_stop_shrink_helper();
>  	}
>  
> +	igt_describe("Check with working set size larger than system memory size "
> +		     "resulting in usage and thrashing of swap space.");
>  	igt_subtest("swap-thrash") {
>  		uint64_t swap_mb = intel_get_total_swap_mb();
>  		igt_require(swap_mb > 0);