[igt-dev] [PATCH i-g-t 2/4] tests/kms_sysfs_edid_timing: fail if probing a single connector takes too long
Luca Coelho
luca at coelho.fi
Tue Jun 7 07:42:38 UTC 2022
From: Luca Coelho <luciano.coelho at intel.com>
There's no point in just warning if probing a single connector takes
too long. If a test finds any issues, it should just fail.
Convert the warning into an assertion.
Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
---
tests/kms_sysfs_edid_timing.c | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
index 028a5323c0b2..ea0e169e6ed9 100644
--- a/tests/kms_sysfs_edid_timing.c
+++ b/tests/kms_sysfs_edid_timing.c
@@ -81,11 +81,11 @@ igt_simple_main
mean.max, mean.max / 1e3, mean.max / 1e6,
mean.mean, mean.mean / 1e3, mean.mean / 1e6);
- if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
- igt_warn("%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
- de->d_name, THRESHOLD_PER_CONNECTOR,
- mean.max / 1e6, mean.mean / 1e6);
- }
+ igt_assert_f(mean.max < THRESHOLD_PER_CONNECTOR * 1e6,
+ "%s: probe time exceed %dms, max=%.2fms, avg=%.2fms\n",
+ de->d_name, THRESHOLD_PER_CONNECTOR,
+ mean.max / 1e6, mean.mean / 1e6);
+
igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
"%s: average probe time exceeded %dms, max=%.2fms, avg=%.2fms\n",
de->d_name, THRESHOLD_TOTAL,
--
2.36.1
More information about the igt-dev
mailing list