[igt-dev] [PATCH 1/2] tests/kms_invalid_mode : Convert tests to dynamic

[Petri Latvala]

On Fri, Jun 10, 2022 at 10:51:18AM +0530, Modem, Bhanuprakash wrote:
> On Mon-06-06-2022 01:21 pm, Petri Latvala wrote:
> > On Mon, Jun 06, 2022 at 08:36:08AM +0300, Gupta, Nidhi1 wrote:
> > > Hi Petri,
> > > 
> > > Thanks for the review.
> > > 
> > > We are trying to convert all the tests in IGT into dynamic tests, for better reporting and get more data just from the name of the subtest to ease the debugging process.
> > > 
> > > Trying to do the same with this test, this test will be executed on every pipe with valid output.
> > 
> > Doing that for a test that doesn't even care about pipes is not
> > achieving anything.
> 
> In this test, we are trying to set invalid output mode on each pipe.
> 
> So, this subtest is running on all pipe/output combinations. Hence, it is
> reasonable to have dynamic subtests. Thoughts?

Yeah, I was lazy and didn't look at the test. The comment stands
though; the loop over the pipes is still there in the test function,
what this patch does is just add another loop that does nothing but
repeat the same test. That then does another loop. Ignoring the pipe
that's given, because it's not even given to the test function.


-- 
Petri Latvala


> 
> - Bhanu
> 
> > 
> > 
>