[igt-dev] [PATCH i-g-t v2 1/4] tests/kms_sysfs_edid_timing: increase max time thresholds

[Kahola, Mika]

> -----Original Message-----
> From: Luca Coelho <luca at coelho.fi>
> Sent: Wednesday, June 15, 2022 3:26 PM
> To: igt-dev at lists.freedesktop.org
> Cc: Latvala, Petri <petri.latvala at intel.com>; Kahola, Mika
> <mika.kahola at intel.com>; luca at coelho.fi
> Subject: [PATCH i-g-t v2 1/4] tests/kms_sysfs_edid_timing: increase max time
> thresholds
> 
> From: Luca Coelho <luciano.coelho at intel.com>
> 
> Currently, some connectors take longer than 10ms to reprobe, so we're getting
> warnings that they take too long.  The times chosen for this test seems to have
> been arbitrary, and it turns out that now they're too short.
> 
> Increase both the per connector threshold and the total time threshold to avoid
> unwarranted warnings.
> 

I'm not sure, what exactly these times should be. Seems that these are more or less based on experiments

Reviewed-by: Mika Kahola <mika.kahola at intel.com>

> Signed-off-by: Luca Coelho <luciano.coelho at intel.com>
> ---
>  tests/kms_sysfs_edid_timing.c | 13 ++++++-------
>  1 file changed, 6 insertions(+), 7 deletions(-)
> 
> diff --git a/tests/kms_sysfs_edid_timing.c b/tests/kms_sysfs_edid_timing.c
> index 12013881b200..028a5323c0b2 100644
> --- a/tests/kms_sysfs_edid_timing.c
> +++ b/tests/kms_sysfs_edid_timing.c
> @@ -26,8 +26,8 @@
>  #include <fcntl.h>
>  #include <sys/stat.h>
> 
> -#define THRESHOLD_PER_CONNECTOR	10
> -#define THRESHOLD_TOTAL		50
> +#define THRESHOLD_PER_CONNECTOR	50
> +#define THRESHOLD_TOTAL		150
>  #define CHECK_TIMES		15
> 
>  IGT_TEST_DESCRIPTION("This check the time we take to read the content of all
> "
> @@ -82,15 +82,14 @@ igt_simple_main
>  			  mean.mean, mean.mean / 1e3, mean.mean / 1e6);
> 
>  		if (mean.max > (THRESHOLD_PER_CONNECTOR * 1e6)) {
> -			igt_warn("%s: probe time exceed 10ms, "
> -				 "max=%.2fms, avg=%.2fms\n", de->d_name,
> +			igt_warn("%s: probe time exceed %dms, max=%.2fms,
> avg=%.2fms\n",
> +				 de->d_name, THRESHOLD_PER_CONNECTOR,
>  				 mean.max / 1e6, mean.mean / 1e6);
>  		}
>  		igt_assert_f(mean.mean < (THRESHOLD_TOTAL * 1e6),
> -			     "%s: average probe time exceeded 50ms, "
> -			     "max=%.2fms, avg=%.2fms\n", de->d_name,
> +			     "%s: average probe time exceeded %dms,
> max=%.2fms, avg=%.2fms\n",
> +			     de->d_name, THRESHOLD_TOTAL,
>  			     mean.max / 1e6, mean.mean / 1e6);
> -
>  	}
>  	closedir(dirp);
> 
> --
> 2.36.1