[igt-dev] [PATCH i-g-t] tests/i915/i915_pm_dc: Check dc3co count to skip the test

[Sharma, Swati2]

On 14-Jun-22 12:16 PM, Mohammed Thasleem wrote:
> dc3co is not enabled in kernel so its required to skip the test.
> Checking counter increment as its allways zero to skip test.

Nitpick: You can re-write commit as
If dc3co is not enabled in driver, counter will always be zero and we 
can simply
skip the test.

Also, put Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/4364

With this corrected.
Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>
> 
> Signed-off-by: Mohammed Thasleem <mohammed.thasleem at intel.com>
> ---
>   tests/i915/i915_pm_dc.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/i915_pm_dc.c b/tests/i915/i915_pm_dc.c
> index 2c2c5086..a780f2cb 100644
> --- a/tests/i915/i915_pm_dc.c
> +++ b/tests/i915/i915_pm_dc.c
> @@ -274,7 +274,8 @@ static void check_dc3co_with_videoplayback_like_load(data_t *data)
>   		usleep(delay);
>   	}
>   
> -	check_dc_counter(data, CHECK_DC3CO, dc3co_prev_cnt);
> +	igt_require_f(dc_state_wait_entry(data->debugfs_fd,
> +		      CHECK_DC3CO, dc3co_prev_cnt), "dc3co-vpb-simulation not enabled\n");
>   }
>   
>   static void require_dc_counter(int debugfs_fd, int dc_flag)

-- 
~Swati Sharma