[igt-dev] [PATCH i-g-t 1/2] i915/gem_tiled_pread_basic: Add test description

[Kamil Konieczny]

Hi Sai,

On 2022-06-16 at 12:01:22 +0530, sai.gowtham.ch at intel.com wrote:
> From: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> 
> Add test description to the test.

Please change commit description as you basically extended old
one with comment present at function description above.
Write also why you think we need to change old one ?

> 
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Sai Gowtham Ch <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_tiled_pread_basic.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/i915/gem_tiled_pread_basic.c b/tests/i915/gem_tiled_pread_basic.c
> index 2b4cec6e..4f3ffb20 100644
> --- a/tests/i915/gem_tiled_pread_basic.c
> +++ b/tests/i915/gem_tiled_pread_basic.c
> @@ -50,7 +50,9 @@
>  #include "i915/gem_create.h"
>  
>  IGT_TEST_DESCRIPTION("Test pread behavior on tiled objects with respect to the"
> -		     " reported swizzling value.");
> +		     " reported swizzling value. The goal is to exercise the"
> +		     " slow_bit17_copy path for reading on bit17 machines,"
> +		     " but will also be useful for catching swizzling value bugs on");
-------------------------------------------------------------------------- ^
Line is too long.

Looks like you dropped words after "on", but I am not sure we
need this whole change.

Regards,
Kamil

>  
>  #define WIDTH 512
>  #define HEIGHT 512
> -- 
> 2.35.1
>