[igt-dev] [PATCH i-g-t 1/2] tests/kms_invalid_mode: Convert tests to dynamic

[Modem, Bhanuprakash]

On Thu-23-06-2022 12:57 pm, Petri Latvala wrote:
> On Thu, Jun 23, 2022 at 11:43:01AM +0530, Modem, Bhanuprakash wrote:
>> On Thu-23-06-2022 11:25 am, Gupta, Nidhi1 wrote:
>>> Hi Bhanu,
>>>
>>> In many tests we are using drm calls, like drmModePageFlip, drmModeSetCrtc, if I will replace it with igt wrapper it will increase the code lines, should I still change it?
>>
>> It's fine to increase the number of lines of code. The idea is to use IGT
>> wrappers wherever it's possible, since IGT helpers were developed
>> purposefully and more handy.
>>
>> Ofcourse, in some tests it is not possible to use these IGT helpers, ex:
>> kms_setmode.
>>
>> @Petri, any thoughts?
> 
> When possible, igt wrappers should be preferred, yes.

Thanks Petri,

@Nidhi, please plan to fix as part of cleanup.

> 
>