[igt-dev] [PATCH i-g-t] tests/kms_concurrent: Fix regression in test_resolution_with_output
Nidhi Gupta
nidhi1.gupta at intel.com
Fri Jun 24 05:00:00 UTC 2022
Fix regression caused by commit 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
to skip the subtest if the suitable resolution is not found.
The kms_concurrent is about testing mode setting with
reducing the resolution and then again increasing it,
for this the test will take the high resolution supported
by the connector and then calculate the lowest resolution,
if the calculated resolution is not supported by the connector
it will assign the default resolution of 1024x 768 without
checking.
Added check to skip the subtest if the current mode is smaller
than 1024 mode (igt_skip_on_f(mode_default->hdisplay < 1024))
becuase if the default resolution is greater then the highest
resolution supported by the connector then the test should skip.
Fixes: 14ad49f5b6ed861eda93e9d6b6ed0f3c77d228d1
Signed-off-by: Nidhi Gupta <nidhi1.gupta at intel.com>
---
tests/kms_concurrent.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/kms_concurrent.c b/tests/kms_concurrent.c
index d4536e3b..6f8ffd4a 100644
--- a/tests/kms_concurrent.c
+++ b/tests/kms_concurrent.c
@@ -252,7 +252,7 @@ get_lowres_mode(data_t *data, const drmModeModeInfo *mode_default,
return igt_memdup(mode, sizeof(*mode));
}
- igt_skip_on_f(mode_default->vdisplay < 1024, "No suitable resolution was found\n");
+ igt_skip_on_f(mode_default->hdisplay < 1024, "No suitable resolution was found\n");
return igt_std_1024_mode_get(igt_output_preferred_vrefresh(output));
}
--
2.26.2
More information about the igt-dev
mailing list