[igt-dev] [i-g-t] tests/kms_cursor_edge_walk: Fix test requirement to avoid SKIPs

Sharma, Swati2 swati2.sharma at intel.com
Tue Jun 28 12:28:53 UTC 2022


Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>

On 24-Jun-22 10:05 AM, Bhanuprakash Modem wrote:
> As (54ff3199) introduced dynamic subtets, tests are getting Skipped
> on all pipes except pipe-A.
> 
> This patch will fix the test requirement condition to avoid such skips.
> 
> Fixes: https://gitlab.freedesktop.org/drm/intel/-/issues/6250
> Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
> ---
>   tests/kms_cursor_edge_walk.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/tests/kms_cursor_edge_walk.c b/tests/kms_cursor_edge_walk.c
> index 526bc6b3..af3769db 100644
> --- a/tests/kms_cursor_edge_walk.c
> +++ b/tests/kms_cursor_edge_walk.c
> @@ -347,11 +347,12 @@ igt_main_args("", long_opts, help_str, opt_handler, &data)
>   		for (i = 0; i < ARRAY_SIZE(tests); i++) {
>   			igt_subtest_with_dynamic(tests[i].name) {
>   				for_each_pipe(&data.display, data.pipe) {
> -					igt_require(data.curw <= max_curw && data.curh <= max_curh);
>   					data.output = igt_get_single_output_for_pipe(&data.display, data.pipe);
>   
>   					for (data.curw = 64; data.curw <= 256; data.curw *= 2) {
>   						data.curh = data.curw;
> +						igt_require(data.curw <= max_curw && data.curh <= max_curh);
> +
>   						igt_dynamic_f("pipe-%s-%s-%dx%d",
>   							      kmstest_pipe_name(data.pipe),
>   							      data.output->name,

-- 
~Swati Sharma


More information about the igt-dev mailing list