[igt-dev] [PATCH i-g-t 1/3] lib/igt_device_scan: fix dangling pointer
Matthew Auld
matthew.auld at intel.com
Tue Jun 28 13:13:16 UTC 2022
It looks like the linkto is out of scope:
../lib/igt_device_scan.c: In function ‘igt_device_add_attr’:
../lib/igt_device_scan.c:368:57: warning: dangling pointer ‘v’ to ‘linkto’ may be used [-Wdangling-pointer=]
368 | g_hash_table_insert(dev->attrs_ht, strdup(key), strdup(v));
| ^~~~~~~~~
../lib/igt_device_scan.c:351:22: note: ‘linkto’ declared here
351 | char linkto[PATH_MAX];
Signed-off-by: Matthew Auld <matthew.auld at intel.com>
Cc: Petri Latvala <petri.latvala at intel.com>
---
lib/igt_device_scan.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/igt_device_scan.c b/lib/igt_device_scan.c
index a1cee7a4..5d1d4258 100644
--- a/lib/igt_device_scan.c
+++ b/lib/igt_device_scan.c
@@ -338,6 +338,7 @@ static void igt_device_add_attr(struct igt_device *dev,
const char *key, const char *value)
{
const char *v = value;
+ char linkto[PATH_MAX];
if (!key)
return;
@@ -348,7 +349,6 @@ static void igt_device_add_attr(struct igt_device *dev,
if (!v) {
struct stat st;
char path[PATH_MAX];
- char linkto[PATH_MAX];
int len;
snprintf(path, sizeof(path), "%s/%s", dev->syspath, key);
--
2.36.1
More information about the igt-dev
mailing list