[igt-dev] [PATCH i-g-t] tests/i915/gem_exec_basic: Add test description to the subtest.

[Kamil Konieczny]

Hi Sai,

Dnia 2022-03-08 at 10:28:19 +0530, sai.gowtham.ch at intel.com napisał(a):
> From: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> 
> Added test description to subtests that are available.

Please send your descripton patches as HAX series, e.g.
add second patch with file tests/intel-ci/fast-feedback.testlist
containing only one line:

igt at meta_test@fail-result

and in cover letter Subject put "HAX add description to [put name of test here]"

See e-mail from Zbigniew on 3 Mar 2022,
"Use HAX for series which add igt_describe"

or https://patchwork.freedesktop.org/series/101198/
as an example.

> 
> Cc: Melkaveri Arjun <Arjun.Melkaveri at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com
> Signed-off-by: Ch Sai Gowtham <sai.gowtham.ch at intel.com>
> ---
>  tests/i915/gem_exec_basic.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/tests/i915/gem_exec_basic.c b/tests/i915/gem_exec_basic.c
> index 008a35d0..16466b05 100644
> --- a/tests/i915/gem_exec_basic.c
> +++ b/tests/i915/gem_exec_basic.c
> @@ -63,6 +63,8 @@ igt_main
>  					    I915_DEVICE_MEMORY);
>  	}
>  
> +	igt_describe("Basic test to check DRM_IOCTL_I915_GEM_EXECBUFFER2 ioctl on"
> +			" every ring, iterating over memory regions.");
-------------------- ^
When you have multi-line string, please align below ones to that
of above, this should looks like

	igt_describe("Basic test to check DRM_IOCTL_I915_GEM_EXECBUFFER2 ioctl on"
		     " every ring, iterating over memory regions.");
^^
(tabulators, then few spaces for align)

Please also change description, e.g. no need to keep long DRM_ ,
something like: 

Check basic functionality of GEM_EXECBUFFER2 ioctl
on every ring and every memory region.

Split it and align accordingly.


>  	igt_subtest_with_dynamic("basic") {
>  		for_each_combination(regions, 1, set) {
>  			char *sub_name = memregion_dynamic_subtest_name(regions);
> -- 
> 2.35.1
> 
Regards,
Kamil