[igt-dev] [PATCH i-g-t 1/2] i915/gem_ctx_exec: Added test description for testcase

[Dandamudi, Priyanka]

-----Original Message-----
From: Kamil Konieczny <kamil.konieczny at linux.intel.com> 
Sent: 09 March 2022 06:59 PM
To: igt-dev at lists.freedesktop.org
Cc: Dandamudi, Priyanka <priyanka.dandamudi at intel.com>; Melkaveri, Arjun <arjun.melkaveri at intel.com>; Kamil Konieczny <kamil.konieczny at linux.intel.com>
Subject: Re: [PATCH i-g-t 1/2] i915/gem_ctx_exec: Added test description for testcase

Hi Priyanka,

please do not resend this, I missed two issues. I would be gratefull if you could reply to first question below.

Dnia 2022-03-09 at 15:17:18 +0530, priyanka.dandamudi at intel.com napisał(a):
> From: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> 
> Added test description to all the available subtests.
> 
> v2: Added description for newly added test case.
> 
> v3: Modified test descriptions.
> 
> Cc: Melkaveri Arjun <arjun.melkaveri at intel.com>
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>
> Signed-off-by: Priyanka Dandamudi <priyanka.dandamudi at intel.com>
> ---
<cut>
>  
> +	igt_describe("Verify that contexts are automatically shotdown"
------------------------------------------------------------ ^ Did you mean "shutdown" here ?
It means contexts need to be killed on close kind of shotdown only.
> +		     " on close, if hangchecking is disabled.");

>  	igt_subtest("basic-nohangcheck")
>  		nohangcheck_hostile(fd);
>  
> +	igt_describe("Race the execution and interrupt handlers along a context,"
> +	             " while closing it at a random time.");
-- ^^^
I missed it here, there are too many spaces. You can catch it with checkpatch or use editor to show white chars (tabs, spaces).

>  	igt_subtest_group {
>  		igt_fixture {
>  			intel_allocator_multiprocess_start();
> @@ -505,6 +515,8 @@ igt_main
>  		}
>  	}
>  
> +	igt_describe("Check if the kernel doesn't leak the vma"
> +		     " pin_count for the last context on reset.");
>  	igt_subtest("reset-pin-leak") {
>  		int i;
>  		uint64_t ahnd;
> --
> 2.25.1
> 

Regards,
Kamil