[igt-dev] [PATCH v2 1/4] lib/igt_psr: pass higher versions of PSR SU panels

Aurabindo Pillai aurabindo.pillai at amd.com
Fri Mar 11 21:30:15 UTC 2022



On 2022-03-11 14:44, David Zhang wrote:
> [why]
>  From eDP 1.5 (eDP 1.4b SCR adopted), a higher version of PSR-SU eDP
> panel, i.e. version 0x4, is added into spec. Need to treat such PSR
> panel as PSR capable sink device.
> 
> [how]
> validate the PSR capable sink for higher PSR version 0x4.
> 
> Cc: Rodrigo Siqueira <rodrigo.siqueira at amd.com>
> Cc: Harry Wentland <harry.wentland at amd.com>
> Cc: Leo Li <sunpeng.li at amd.com>
> Cc: Jay Pillai <aurabindo.pillai at amd.com>
> Cc: Wayne Lin <wayne.lin at amd.com>
> 
> Signed-off-by: David Zhang <dingchen.zhang at amd.com>
> ---
>   lib/igt_psr.c | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/igt_psr.c b/lib/igt_psr.c
> index 98eb28b4..2b73e809 100644
> --- a/lib/igt_psr.c
> +++ b/lib/igt_psr.c
> @@ -209,8 +209,14 @@ bool psr_sink_support(int device, int debugfs_fd, enum psr_mode mode)
>   		/*
>   		 * i915 requires PSR version 0x03 that is PSR2 + SU with
>   		 * Y-coordinate to support PSR2
> +		 *
> +		 * or
> +		 *
> +		 * PSR version 0x4 that is PSR2 + SU w/ Y-coordinate and SU
> +		 * Region Early Transport to support PSR2 (eDP 1.5)
>   		 */
> -		return strstr(buf, "Sink support: yes [0x03]");
> +		return strstr(buf, "Sink support: yes [0x03]") ||
> +		       strstr(buf, "Sink support: yes [0x04]");
>   }
>   
>   #define PSR2_SU_BLOCK_STR_LOOKUP "PSR2 SU blocks:\n0\t"


Except for nitpicks, with changes addressed, the series is:

Reviewed-by: Aurabindo Pillai <aurabindo.pillai at amd.com>


More information about the igt-dev mailing list