[igt-dev] [PATCH i-g-t] i915_module_load: Unload the module before exiting the subtest

[Bhanuprakash Modem]

On DP-MST setup, after execution of "reload" subtest, i915
became unloadable. And this is effecting the next subtest
"reload-no-display".

Observing below error, if we run all subtests of i915_module_load
(or) run "reload" & "reload-no-display" in same order using the
igt_runner. But not seen any issue if we run each subtest individually.

$ ./igt_runner -o -l verbose -s --test-list tests.txt --use-watchdog ../tests/ results/
(or)
$ ./build/tests/i915_module_load
  Starting subtest: reload
  ...
  Subtest reload: SUCCESS (3.780s)

  Starting subtest: reload-no-display
  (i915_module_load:42617) igt_kmod-WARNING: Could not unload i915
  Module                   Used by
  i915                     1
  ...
  Reloading i915 with disable_display=1
  Module i915 already inserted
  Could not load i915
  Subtest reload-no-display: FAIL (1.998s)

$ ./build/tests/i915_module_load --r reload
  Starting subtest: reload
  ...
  Subtest reload: SUCCESS (5.562s)
$ ./build/tests/i915_module_load --r reload-no-display
  Starting subtest: reload-no-display
  ...
  Subtest reload-no-display: SUCCESS (7.995s)

This patch will unload the module before exiting the subtest. So
that we can make sure that the module is unloaded.

Cc: Chris Wilson <chris at chris-wilson.co.uk>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
---
 tests/i915/i915_module_load.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tests/i915/i915_module_load.c b/tests/i915/i915_module_load.c
index a86dd86cd0..c641a6a989 100644
--- a/tests/i915/i915_module_load.c
+++ b/tests/i915/i915_module_load.c
@@ -249,7 +249,7 @@ igt_main
 
 		gem_sanitycheck();
 
-		/* only default modparams, can leave module loaded */
+		igt_i915_driver_unload();
 	}
 
 	igt_subtest("reload-no-display") {
-- 
2.35.1