[igt-dev] [PATCH i-g-t v2 0/8] Writeback fixes and improvements

[Maxime Ripard]

Hi,

Here's a series addressing the writeback-check-output test not passing
on vc4. This is due to the fact that the writeback controller will force
the X component to 0, while we expect the output and input buffers to be
identical, and the input buffer has 0xff.

This series tackles this by adding some support to dump the faulty
frames in PNG and raw, which proved to be useful while debugging this
series. Then, we rework the hash function to ignore the X component of
our buffer and only hash the pixels themselves.

Finally, we change the input buffer X value to a garbage, different from
0 and 0xff, value to make sure the hardware properly ignores the
component and doesn't treat it as alpha.

Let me know what you think,
Maxime

Changes from v1:
  - Rebased on master
  - Added maintainers to the recipients

Maxime Ripard (8):
  lib/igt_frame: Rename summary fd variable
  lib/igt_frame: Move frame dump logging to function
  lib/igt_frame: Move frame path creation to function
  lib/igt_frame: Add function to dump frames in RGB and raw
  tests/kms_writeback: Use endianness accessor to fill pixels
  tests/kms_writeback: Dump the frames if the don't match
  lib/igt_fb: Ignore the X component when computing CRC
  tests/kms_writeback: Use a garbage X value to create fill our test
    buffer

 lib/igt_core.h        |   9 +++
 lib/igt_fb.c          |  20 ++++--
 lib/igt_frame.c       | 137 ++++++++++++++++++++++++++++++++++++------
 lib/igt_frame.h       |   4 ++
 tests/kms_writeback.c |  40 +++++++++++-
 5 files changed, 185 insertions(+), 25 deletions(-)

-- 
2.35.1