[igt-dev] [PATCH i-g-t] runner: Override results for subtests even when there's dynamic subtests

[Sharma, Swati2]

LGTM.

Reviewed-by:  Swati Sharma <swati2.sharma at intel.com>

On 31-Mar-22 6:18 PM, Petri Latvala wrote:
> igt_runner converts passing test results to warn if a test outputs
> stuff to stderr. It also converts results if kernel logs contain
> warnings to dmesg-warn or dmesg-fail, depending on the test's own
> result.
> 
> Perform this same conversion to subtests even if they contain dynamic
> subtests, now that we have the capability of keeping those around.
> 
> Signed-off-by: Petri Latvala <petri.latvala at intel.com>
> Cc: Swati Sharma <swati2.sharma at intel.com>
> ---
>   runner/resultgen.c | 6 ++----
>   1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/runner/resultgen.c b/runner/resultgen.c
> index 76f9fb7d..6ecf325b 100644
> --- a/runner/resultgen.c
> +++ b/runner/resultgen.c
> @@ -1385,10 +1385,8 @@ static void override_results(char *binary,
>   
>   	for (i = 0; i < subtests->size; i++) {
>   		generate_piglit_name(binary, subtests->subs[i].name, piglit_name, sizeof(piglit_name));
> -		if (subtests->subs[i].dynamic_size == 0) {
> -			obj = get_or_create_json_object(tests, piglit_name);
> -			override_result_single(obj);
> -		}
> +		obj = get_or_create_json_object(tests, piglit_name);
> +		override_result_single(obj);
>   
>   		for (k = 0; k < subtests->subs[i].dynamic_size; k++) {
>   			generate_piglit_name_for_dynamic(piglit_name, subtests->subs[i].dynamic_names[k],

-- 
~Swati Sharma