[igt-dev] [PATCH i-g-t 3/3] i915_pm_rpm: rpm resume by user forcewake

Dixit, Ashutosh ashutosh.dixit at intel.com
Wed May 4 04:32:53 UTC 2022


On Tue, 03 May 2022 19:51:24 -0700, Dixit, Ashutosh wrote:
>
> > Change function name to disable_all_screens_and_clr_forcewake_and_wait()
> > (s/or/and/) since we are doing both?
>
> Or we could do this:
>
>	if (data->fw_fd)
>		clear_forcewake(data);
>
> Basically, I think either make both enable and disable functions
> unconditional, or set/clear forcewake in both only for headless (and name
> the functions appropriately).

I think the code will be clearer if we do in only for headless (as is in
the patch) but we could just make the above change in the disable function.


More information about the igt-dev mailing list