[igt-dev] [PATCH i-g-t v2 6/8] tests/kms_writeback: Dump the frames if the don't match

[Maxime Ripard]

On Fri, Apr 29, 2022 at 03:55:15PM +0300, Pekka Paalanen wrote:
> On Mon, 28 Mar 2022 16:55:07 +0200
> Maxime Ripard <maxime at cerno.tech> wrote:
> 
> > The writeback tests will make sure the reference and captured frames
> > match. If they don't however, we don't get anything but their hash which
> > isn't really helpful.
> > 
> > Add a function similar to chamelium_assert_crc_eq_or_dump() to dump the
> > PNG and raw buffers of those two frames if they don't match and frame
> > dumping has been enabled.
> > 
> > Signed-off-by: Maxime Ripard <maxime at cerno.tech>
>
> FWIW, in Weston we write out also the error visualization image with the
> mismatching areas highlighted:
> https://gitlab.freedesktop.org/wayland/weston/-/blob/69a59359fa8590074717e211d332c1077d8f277f/tests/weston-test-client-helper.c#L1405-1433

That's cool, I wonder if we could leverage this for the chamelium as
well.

maxime