[igt-dev] [PATCH 1/4] tests/amdgpu/amd_psr: some fix for PSR-SU MPO test case
David Zhang
dingchen.zhang at amd.com
Thu May 5 21:32:23 UTC 2022
[why]
Analogous to usermode behavior, when there are primary plane and
overlay plane committed, alpha region of overlay corresponding to
the primary plane position/size should be set to zero to explicitly
display the content of primary plane (emulated as video playback in
this test case) in general.
The input arguments of width/height of the helper to paint the
framebuffer should not exceed the size of the created framebuffer.
[how]
- set the alpha region of overlay plane framebuffer to zero aligned
to the position/size of the primary plane
- paint the primary plane framebuffer background/foreground w/ the
valid width/height.
Cc: Rodrigo Siqueira <rodrigo.siqueira at amd.com>
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Leo Li <sunpeng.li at amd.com>
Cc: Jay Pillai <aurabindo.pillai at amd.com>
Cc: Wayne Lin <wayne.lin at amd.com>
Signed-off-by: David Zhang <dingchen.zhang at amd.com>
---
tests/amdgpu/amd_psr.c | 18 ++++++++++++++----
1 file changed, 14 insertions(+), 4 deletions(-)
diff --git a/tests/amdgpu/amd_psr.c b/tests/amdgpu/amd_psr.c
index b930b20e..5d190720 100644
--- a/tests/amdgpu/amd_psr.c
+++ b/tests/amdgpu/amd_psr.c
@@ -351,9 +351,9 @@ static void run_check_psr_su_mpo(data_t *data)
cr = igt_get_cairo_ctx(data->fd, &rect_fb[i]);
igt_assert_f(cr, "Failed to get cairo context\n");
/* background in black */
- igt_paint_color(cr, 0, 0, data->w, data->h, .0, .0, .0);
+ igt_paint_color(cr, 0, 0, data->w / 2, data->h / 2, .0, .0, .0);
/* foreground (megenta strip) */
- igt_paint_color(cr, i * strip_w, 0, strip_w, data->h, 1.0, .0, 1.0);
+ igt_paint_color(cr, i * strip_w, 0, strip_w, data->h / 2, 1.0, .0, 1.0);
igt_put_cairo_ctx(cr);
}
@@ -364,8 +364,18 @@ static void run_check_psr_su_mpo(data_t *data)
igt_plane_set_position(data->primary, 0, 0);
igt_plane_set_size(data->primary, data->w / 2, data->h / 2);
- /* adjust alpha for vpb (primary plane) region in overlay */
- draw_color_alpha(&ov_fb, 0, 0, data->w / 2, data->h / 2, .5, .5, .5, .3);
+ /**
+ * adjust alpha for vpb (primary plane) region in overlay
+ * given alpha, we have:
+ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ * blended = alpha * toplay + (1 - alpha) * underlay
+ * ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
+ * since primary plane is underlay while overlay plane is toplay, to
+ * display the content of primary plane w/ blending, we'd set the alpha
+ * of each pixel in overlay corresponding to primary plane position/size
+ * to be zero.
+ */
+ draw_color_alpha(&ov_fb, 0, 0, data->w / 2, data->h / 2, .5, .5, .5, .0);
igt_output_set_pipe(data->output, data->pipe_id);
igt_display_commit_atomic(&data->display, 0, NULL);
--
2.25.1
More information about the igt-dev
mailing list