[igt-dev] [v4 05/15] tests/kms_color: New subtests for Plane degamma
Bhanuprakash Modem
bhanuprakash.modem at intel.com
Fri May 6 05:44:36 UTC 2022
To verify Plane degamma, draw 3 gradient rectangles in red, green and blue,
with a maxed out degamma LUT and verify we have the same CRC as drawing solid
color rectangles without degamma.
v2:
* Add support to validate 'no degamma' mode (Harry)
Cc: Harry Wentland <harry.wentland at amd.com>
Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
Cc: Pekka Paalanen <ppaalanen at gmail.com>
Cc: Uma Shankar <uma.shankar at intel.com>
Signed-off-by: Bhanuprakash Modem <bhanuprakash.modem at intel.com>
---
tests/kms_color.c | 129 ++++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 129 insertions(+)
diff --git a/tests/kms_color.c b/tests/kms_color.c
index 7d7656d7..196952e2 100644
--- a/tests/kms_color.c
+++ b/tests/kms_color.c
@@ -760,6 +760,130 @@ static bool plane_gamma_test(data_t *data, igt_plane_t *plane)
return ret;
}
+static bool plane_degamma_test(data_t *data, igt_plane_t *plane)
+{
+ igt_output_t *output;
+ igt_display_t *display = &data->display;
+ drmModeModeInfo *mode;
+ drmModePropertyPtr degamma_mode;
+ struct igt_fb fb;
+ uint32_t i;
+ bool ret = true;
+ igt_pipe_crc_t *pipe_crc = NULL;
+ color_t red_green_blue[] = {
+ { 1.0, 0.0, 0.0 },
+ { 0.0, 1.0, 0.0 },
+ { 0.0, 0.0, 1.0 }
+ };
+
+ igt_info("Plane degamma test is running on pipe-%s plane-%d(%s)\n",
+ kmstest_pipe_name(plane->pipe->pipe), plane->index,
+ kmstest_plane_type_name(plane->type));
+
+ igt_require(igt_plane_has_prop(plane, IGT_PLANE_DEGAMMA_MODE));
+ igt_require(igt_plane_has_prop(plane, IGT_PLANE_DEGAMMA_LUT));
+
+ pipe_crc = igt_pipe_crc_new(data->drm_fd,
+ plane->pipe->pipe,
+ INTEL_PIPE_CRC_SOURCE_AUTO);
+
+ output = igt_get_single_output_for_pipe(display, plane->pipe->pipe);
+ igt_assert(output);
+
+ igt_output_set_pipe(output, plane->pipe->pipe);
+ mode = igt_output_get_mode(output);
+
+ /* Create a framebuffer at the size of the output. */
+ igt_assert(igt_create_fb(data->drm_fd,
+ mode->hdisplay,
+ mode->vdisplay,
+ DRM_FORMAT_XRGB8888,
+ DRM_FORMAT_MOD_LINEAR,
+ &fb));
+
+ igt_plane_set_fb(plane, &fb);
+
+ /* Disable Pipe color props. */
+ disable_ctm(plane->pipe);
+ disable_degamma(plane->pipe);
+ disable_gamma(plane->pipe);
+
+ disable_plane_ctm(plane);
+ disable_plane_gamma(plane);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+
+ degamma_mode = get_plane_gamma_degamma_mode(plane, IGT_PLANE_DEGAMMA_MODE);
+
+ /* Iterate all supported degamma modes. */
+ for (i = 0; i < degamma_mode->count_enums; i++) {
+ igt_crc_t crc_degamma, crc_fullcolors;
+ segment_data_t *segment_info = NULL;
+ struct drm_color_lut_ext *lut = NULL;
+ uint32_t lut_size = 0;
+
+ igt_info("Trying to use degamma mode: \'%s\'\n", degamma_mode->enums[i].name);
+
+ /* Draw solid colors with no degamma. */
+ disable_plane_degamma(plane);
+ paint_rectangles(data, mode, red_green_blue, &fb);
+ igt_plane_set_fb(plane, &fb);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[plane->pipe->pipe].crtc_offset);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_fullcolors);
+
+ /* 'no degamma' is intended to disable the degamma.
+ * Hence, setting DEGAMMA_LUT to NULL (i.e disable_plane_degamma())
+ * and setting DEGAMMA_MODE as 'no degamma' (i.e set_plane_degamma())
+ * should produce the same result.
+ */
+ if (strcmp(degamma_mode->enums[i].name, "no degamma")) {
+ segment_info = get_segment_data(data,
+ degamma_mode->enums[i].value,
+ degamma_mode->enums[i].name);
+ lut_size = sizeof(struct drm_color_lut_ext) * segment_info->entries_count;
+ lut = create_max_lut(segment_info);
+ if (is_i915_device(data->drm_fd))
+ lut[0].red = lut[0].green = lut[0].blue = 0; /* First entry is 0 for Intel h/w. */
+
+ /* Draw gradient colors with degamma LUT to remap all
+ * values to max red/green/blue.
+ */
+ paint_gradient_rectangles(data, mode, red_green_blue, &fb);
+ igt_plane_set_fb(plane, &fb);
+ }
+
+ set_plane_degamma(plane, degamma_mode->enums[i].name, lut, lut_size);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+ igt_wait_for_vblank(data->drm_fd,
+ display->pipes[plane->pipe->pipe].crtc_offset);
+ igt_pipe_crc_collect_crc(pipe_crc, &crc_degamma);
+
+ /* Verify that the CRC of the software computed output
+ * is equal to the CRC of the degamma LUT transformation
+ * output.
+ */
+ ret &= igt_check_crc_equal(&crc_degamma, &crc_fullcolors);
+
+ free(lut);
+ clear_segment_data(segment_info);
+ }
+
+ disable_plane_degamma(plane);
+ igt_plane_set_fb(plane, NULL);
+ igt_output_set_pipe(output, PIPE_NONE);
+ igt_display_commit2(display, display->is_atomic ?
+ COMMIT_ATOMIC : COMMIT_LEGACY);
+
+ igt_pipe_crc_free(pipe_crc);
+ drmModeFreeProperty(degamma_mode);
+
+ return ret;
+}
+
static void
prep_pipe(data_t *data, enum pipe p)
{
@@ -1110,6 +1234,11 @@ static void run_tests_for_plane(data_t *data, enum pipe pipe)
igt_describe("Compare maxed out plane gamma LUT and solid color linear LUT");
igt_subtest_f("pipe-%s-plane-gamma", kmstest_pipe_name(pipe))
run_plane_color_test(data, pipe, plane_gamma_test);
+
+ igt_describe("Compare maxed out plane degamma LUT and solid color linear LUT");
+ igt_subtest_f("pipe-%s-plane-degamma",
+ kmstest_pipe_name(pipe))
+ run_plane_color_test(data, pipe, plane_degamma_test);
}
static int opt_handler(int opt, int opt_index, void *data)
--
2.35.1
More information about the igt-dev
mailing list