[igt-dev] [PATCH] tests/i915/gem_exec_balancer: Add busy subtest description

Kamil Konieczny kamil.konieczny at linux.intel.com
Mon May 9 15:55:39 UTC 2022


Hi Sinjan,

On 2022-05-06 at 19:54:45 +0530, sinjan.kumar at intel.com wrote:
> From: Sinjan Kumar <sinjan.kumar at intel.com>
> 
> Add busy subtest description
> 
> Cc: Kamil Konieczny <kamil.konieczny at linux.intel.com>

If you sended this mail to other developers, please put more
addresses here.

> Signed-off-by: Sinjan Kumar <sinjan.kumar at intel.com>
> ---
>  tests/i915/gem_exec_balancer.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/tests/i915/gem_exec_balancer.c b/tests/i915/gem_exec_balancer.c
> index 857d0085..c68a50e7 100644
> --- a/tests/i915/gem_exec_balancer.c
> +++ b/tests/i915/gem_exec_balancer.c
> @@ -3301,6 +3301,9 @@ igt_main
>  	igt_subtest("indices")
>  		indices(i915);
>  
> +	igt_describe("Test for validating engine busyness by checking"
> +		     " read-write event through GEM_BUSY IOCTL");
> +

Please remove this empty line. Please try to avoid starting
desciption with "Test" word (well, sometimes you can use it).
Here you could start with "Validate" word:

	igt_describe("Validate engine busyness by checking read-write"
		     " event through GEM_BUSY IOCTL.");

For future versions of this and other description patches please
send them as HAX series, e.g. add second patch with file
tests/intel-ci/fast-feedback.testlist
containing only one line:

igt at meta_test@fail-result

and with subject "HAX: do not run tests", also in cover letter
subject put "HAX add description to [put name of test here]"

See e-mail from Zbigniew on 3 Mar 2022,
"Use HAX for series which add igt_describe"

or https://patchwork.freedesktop.org/series/101198/
as an example.

>  	igt_subtest("busy")
>  		busy(i915);

May you add more descriptions for other subtests ? Check them
with --describe option.

Regards,
Kamil

>  
> -- 
> 2.25.1
> 


More information about the igt-dev mailing list