[igt-dev] [PATCH i-g-t 06/14] tests/amdgpu: Remove unused headers

Ryszard Knop ryszard.knop at intel.com
Tue May 31 14:28:36 UTC 2022


Using CLion's automated code inspection, most unused includes were found
and removed. Some warnings remain as CLion is unable to track code usage
across certain attributes, but the vast majority of unneeded headers are
now gone.

Signed-off-by: Ryszard Knop <ryszard.knop at intel.com>
---
 tests/amdgpu/amd_abm.c    | 2 --
 tests/amdgpu/amd_assr.c   | 2 --
 tests/amdgpu/amd_basic.c  | 5 +----
 tests/amdgpu/amd_dp_dsc.c | 1 -
 tests/amdgpu/amd_ilr.c    | 4 ----
 tests/amdgpu/amd_info.c   | 2 --
 6 files changed, 1 insertion(+), 15 deletions(-)

diff --git a/tests/amdgpu/amd_abm.c b/tests/amdgpu/amd_abm.c
index 9400ed80..815de85b 100644
--- a/tests/amdgpu/amd_abm.c
+++ b/tests/amdgpu/amd_abm.c
@@ -20,7 +20,6 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "igt.h"
 #include "drmtest.h"
 #include "igt_kms.h"
 #include <limits.h>
@@ -30,7 +29,6 @@
 #include <stdio.h>
 #include <string.h>
 #include <fcntl.h>
-#include <time.h>
 
 #define DEBUGFS_CURRENT_BACKLIGHT_PWM "amdgpu_current_backlight_pwm"
 #define DEBUGFS_TARGET_BACKLIGHT_PWM "amdgpu_target_backlight_pwm"
diff --git a/tests/amdgpu/amd_assr.c b/tests/amdgpu/amd_assr.c
index 80cbbe8e..79510732 100644
--- a/tests/amdgpu/amd_assr.c
+++ b/tests/amdgpu/amd_assr.c
@@ -24,8 +24,6 @@
 #include "igt_sysfs.h"
 #include <dirent.h>
 #include <fcntl.h>
-#include <limits.h>
-#include <sys/types.h>
 #include <sys/stat.h>
 
 IGT_TEST_DESCRIPTION("Check if ASSR is enabled on eDP links that support "
diff --git a/tests/amdgpu/amd_basic.c b/tests/amdgpu/amd_basic.c
index 6c9609b9..ab08fb8c 100644
--- a/tests/amdgpu/amd_basic.c
+++ b/tests/amdgpu/amd_basic.c
@@ -22,13 +22,10 @@
  * Based on libdrm/tests/amdgpu/basic_tests.c
  */
 
-#include "config.h"
-
-#include <stdio.h>
 #include <stdlib.h>
 #include <unistd.h>
 #ifdef HAVE_ALLOCA_H
-# include <alloca.h>
+#include <alloca.h>
 #endif
 
 #include "drmtest.h"
diff --git a/tests/amdgpu/amd_dp_dsc.c b/tests/amdgpu/amd_dp_dsc.c
index 8a18df3b..b818a3bc 100644
--- a/tests/amdgpu/amd_dp_dsc.c
+++ b/tests/amdgpu/amd_dp_dsc.c
@@ -22,7 +22,6 @@
 
 #include "igt.h"
 #include "igt_amd.h"
-#include "sw_sync.h"
 #include <fcntl.h>
 #include <signal.h>
 
diff --git a/tests/amdgpu/amd_ilr.c b/tests/amdgpu/amd_ilr.c
index 50ca93a1..27376ea1 100644
--- a/tests/amdgpu/amd_ilr.c
+++ b/tests/amdgpu/amd_ilr.c
@@ -22,11 +22,7 @@
 
 #include "igt.h"
 #include "igt_amd.h"
-#include "igt_sysfs.h"
 #include <dirent.h>
-#include <fcntl.h>
-#include <limits.h>
-#include <sys/types.h>
 #include <sys/stat.h>
 
 #define MULTIPLIER_TO_LR 270000
diff --git a/tests/amdgpu/amd_info.c b/tests/amdgpu/amd_info.c
index d6aea827..b53b4dc0 100644
--- a/tests/amdgpu/amd_info.c
+++ b/tests/amdgpu/amd_info.c
@@ -21,8 +21,6 @@
  * OTHER DEALINGS IN THE SOFTWARE.
  */
 
-#include "config.h"
-
 #include "igt.h"
 
 #include <amdgpu.h>
-- 
2.36.1



More information about the igt-dev mailing list